Launchpad itself

Candidate job selection logic needs to observe the 'virtualized' setting

Bug #507323 reported by Muharem Hrnjadovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Muharem Hrnjadovic
Launchpad itself 10.01

Bug Description

Right now 'virtualized' is ignored when the 'processor' property is not set. However, even for processor-independent jobs we should observe the former and dispatch the jobs to native or virtual builders as appropriate.

See original description

Related branches

lp://staging/~al-maisan/launchpad/observe-virtualized-507323
Paul Hummer (community): Approve (code)
Diff: 32 lines (+15/-6)
1 file modified
lib/lp/buildmaster/model/builder.py (+15/-6)
Muharem Hrnjadovic (al-maisan)
Changed in soyuz:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Muharem Hrnjadovic (al-maisan)
milestone: none → 10.01
description: updated
tags: added: buildfarm
Revision history for this message
Muharem Hrnjadovic (al-maisan) wrote :

Related to bug #503836.

Muharem Hrnjadovic (al-maisan)
Changed in soyuz:
status: Triaged → In Progress
Revision history for this message
Muharem Hrnjadovic (al-maisan) wrote :

My understanding of this is as follows:

  - if the 'virtualized' property value matches for a Builder and a BuildQueue record then add the latter to the set of potential candidates
  - if a BuildQueue record's 'virtualized' property is not set (IS NULL) then only add it to the set of potential candidates if the builder is a virtual one. This is a security measure meant to preclude the execution of untrusted code on native builders.

Revision history for this message
William Grant (wgrant) wrote :

I think I would prefer if virtualized was mandatory, but this looks fine.

Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in db r8872 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-devel/revision/8872>

Changed in soyuz:
status: In Progress → Fix Committed
Muharem Hrnjadovic (al-maisan)
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.