Assign to group ... does nothing

Bug #503294 reported by Poil
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Terminator
Fix Released
Undecided
Chris Jones

Bug Description

I'm using 0.14 since 1 week :
On terminator 0.13 I can assign one window to a new group, a popup window was displayed where I could write the group name.
On terminator 0.14, if I click on "Assign to group ..." I don't have any popup window
Other function seem working fine, I can group all in tab, ungroup, broadcast ...

I'm using RHEL 5.4 x86, Python 2.4.3

Revision history for this message
Chris Jones (cmsj) wrote :

Could you please run Terminator from inside a terminal and see if it produces any python tracebacks at that point, please?

Changed in terminator:
status: New → Incomplete
Revision history for this message
Poil (poil) wrote :

Here it is :

/home/xxxxxx/.themes/ColorBit/gtk-2.0/gtkrc:72: error: unexpected identifier `colorize_scrollbar', expected character `}'
Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/terminatorlib/terminatorterm.py", line 1654, in create_group
    window_x, window_y = self.get_window().get_origin()
AttributeError: 'TerminatorTerm' object has no attribute 'get_window'

Best regards

Revision history for this message
Chris Jones (cmsj) wrote :

Perfect thanks, it would seem that we're using PyGTK calls that are only in 2.14 or newer, which is why that method is failing on RHEL 5.4.
I've committed a fix to trunk at revision 802, but this seems serious enough that I should probably do another release fairly soon. I'd like to get myself an old distro in a VM so I can test on python 2.4 and an old pygtk (mostly I'm using the latest Ubuntu releases, so I'm on python 2.6 and pygtk 2.16) to catch any others.

Changed in terminator:
assignee: nobody → Chris Jones (cmsj)
status: Incomplete → Fix Committed
Revision history for this message
chantra (chantra) wrote :

Chris,

A while back I created https://code.edge.launchpad.net/~chantra/terminator/python2.12-compat

here is the diff: http://bazaar.launchpad.net/~chantra/terminator/python2.12-compat/revision/778
actually, it should be proposed for merge in trunk through LP.

Basically, what it does is to wrap widget.get_window() into gtk_widget_get_window()

That was meant to fix "Bug #314233: Simultaneous typing in multiple grouped terminals send all the output to one terminal" : https://bugs.edge.launchpad.net/terminator/+bug/314233

to make terminator pygtk 2.12 compatible.

There might be some better ways to wrap it, mainly once epic-refactor is sorted out.

It is a same the method did not exist in pygtk 2.12 :)

Chris Jones (cmsj)
Changed in terminator:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.