[saydo] saydo matches too leniently, causing errors
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ibid |
Fix Released
|
Low
|
Jonathan Hitchcock |
Bug Description
2009-12-21 21:26:23,261 DEBUG source.atrum: Received message from Vhata in Spinach: do you care for sodomy?
2009-12-21 21:26:23,261 DEBUG core.dispatcher: Received event from atrum source
2009-12-21 21:26:23,269 DEBUG core.auth: Checking saydo permission for 1/1 (Vhata!<email address hidden>) from cache: auth
2009-12-21 21:26:23,612 DEBUG source.atrum: Authentication result for Vhata: True
2009-12-21 21:26:23,677 INFO core.auth: Authenticated 1/1 (Vhata!<email address hidden>) using nickserv
2009-12-21 21:26:23,701 ERROR core.dispatcher: Exception occured in Log processor of log plugin.
Event: {'account': 1L, 'responses': [{'action': True, 'reply': u'care for sodomy?', 'address': False, 'target': u'you', 'source': None}], 'source': u'atrum', 'addressed': True, 'session': <sqlalchemy.
etime.datetime(
channel': u'Vhata!<email address hidden>', 'sender': {'nick': u'Vhata', 'connection': u'Vhata!<email address hidden>', 'id': u'Vhata'}}
Traceback (most recent call last):
File "/home/
processor.
File "/home/
self.
File "/home/
channel = ibid.sources[
File "/home/
return dict.__
AttributeError: 'NoneType' object has no attribute 'lower'
2009-12-21 21:26:23,701 DEBUG core.dispatcher: {'account': 1L, 'responses': [{'action': True, 'reply': u'care for sodomy?', 'address': False, 'target': u'you', 'source': None}], 'complain': u'exception', 'source': u'atrum', 'addressed': True, 'processed': True, 'time':
datetime.
"do you care for sodomy?" appears to be being interpreted as "do [in] you [on source None] care for sodomy?"
Adminny commands like saydo don't need to be as lenient matching: they can require strict syntax so they don't get in the way of normal stuff.
Related branches
- Michael Gorven: Approve
- Stefano Rivera: Approve
-
Diff: 16 lines (+2/-2)1 file modifiedibid/plugins/basic.py (+2/-2)
Changed in ibid: | |
assignee: | nobody → Jonathan Hitchcock (vhata) |
importance: | Undecided → Low |
milestone: | none → 0.1 |
status: | New → In Progress |
Changed in ibid: | |
status: | In Progress → Fix Released |