Branch.pull() doesn't shortcut when last_revision is identical
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Medium
|
Unassigned |
Bug Description
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I'm not sure when this changed, but Branch.
checks if other_branch.
nothing to do.
Which means that even without changes, the fetch code is invoked, and
the graph search code is triggered. (Causing us to read the remote
revision indexes looking for the parents of the current last_revision, etc.)
I don't think it would be hard to fix this, but I guess there is some
concern about increasing the number of round trips. (It *shouldn't* as
we need to know the last_revision of the remote branch to start the pull
anyway, and we likely have the local last_revision cheaply as well.)
In my testing, this is a rather significant round-trip improvement for
no-op pulls.
affects bzr
status confirmed
importance medium
tags easy performance
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAks
Wi4AoJ94gMOf4Yk
=mFGY
-----END PGP SIGNATURE-----
tags: | added: check-for-breezy |
I suspect this has been fixed.