GTG

Tag color cannot be unset

Bug #496882 reported by Lionel Dricot
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
GTG
Fix Released
High
Matthew Rasmus

Bug Description

There's currently no way to unset the color of a tag. That's quite a big usability issue.

Tags: toreview

Related branches

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

This is related to bug #320264

Changed in gtg:
status: New → Confirmed
importance: Undecided → High
milestone: none → 0.3
Revision history for this message
Matthew Rasmus (mrasmus) wrote :

I pushed a branch that fixes this--you can reset a tags color by right clicking a tag in the tag sidebar and selecting "Reset Color."

I'm new to this, so hopefully I didn't do anything horribly wrong. :)

tags: added: toreview
Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

Hi Matthew, it's always fun to have new contributor :-)

You didn't do anything wrong but, personally, I would not put that option in the right click menu directly. I would prefer to have it in the color choosing dialog (see also bug #320264 ). But this is only my opinion, it could be discussed.

Anyway, I'm really glad that someone work on this bug, welcome :-)

Revision history for this message
Bertrand Rousseau (bertrand-rousseau) wrote :

>Lionel I agree with you but maybe before having a full tag properties editor (allowing for instance, to select colors or icons) I think we could have this quick fix to reset colors.

Revision history for this message
Matthew Rasmus (mrasmus) wrote :

I'd like to contribute more, but I figured that this would be a simple enough issue to deal with while getting familiar with the code. I agree, though, that it would be better placed in a tag editor dialog. Until then I hope this is good enough. :)

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

If we agree that it's a temporary fix then I think it's OK.

Revision history for this message
Ashton Kemerling (ashtonkemerling) wrote :

Maybe we could combine this with the #TODO in the code stating that there should be a separate tag editor, like how we have a task editor.

Changed in gtg:
status: Confirmed → Fix Committed
assignee: nobody → Matthew Rasmus (mrasmus)
Changed in gtg:
milestone: 0.3 → 0.2.1
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.