Remove coverart and lyrics from automagically loaded track tags

Bug #490511 reported by Abhishek Mukherjee
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Medium
reacocard

Bug Description

15:26 < reacocard> GuyFromHell: yeah, coverart and lyrics need to not load automagically
15:29 < reacocard> here's a thought.. add a method to Track to get a raw tag directly from the file, and
                   have that cache the mutagen tag reader object it gets from xl/metadata internally for x
                   # of seconds
15:29 < reacocard> we dont need to hold it for very long, since the only time re-reading it is going to be
                   significantly bad is at the start of playback of a track, when it might all get
                   accessed in quick succession
15:30 < reacocard> so like, 30 second timeout would probably be more than enough
15:31 < reacocard> then we just blacklist cover and lyrics from automagic loading in xl/metadata and call
                   it good
15:31 < reacocard> ofc, that wont help people whose dbs already have that data in them, but it will help
                   fresh dbs

Changed in exaile:
assignee: nobody → Abhishek Mukherjee (linkinpark342)
Revision history for this message
reacocard (reacocard) wrote :

in keeping with the rest of the tag access methods, get_tag_disk(), maybe? same as _raw, but always pulls from disk. no need for _display and _sort counterparts.

it might also be easier to blacklist cover/lyrics in the Track tags loader instead of xl/metadata, not sure. figure it out when it gets implemented.

reacocard (reacocard)
Changed in exaile:
importance: Undecided → Medium
milestone: none → 0.3.1
status: New → Confirmed
Revision history for this message
Abhishek Mukherjee (linkinpark342) wrote :

Aren seems to have already handled this and put in most of the code so I assigned it to him. There's a patch attached here that actually nukes the coverart tag if it's read. This got me saving something like 50MB of memory. I don't actually know if it works with the cacher but it works theoretically >_>

Changed in exaile:
assignee: Abhishek Mukherjee (linkinpark342) → Aren Olson (reacocard)
reacocard (reacocard)
Changed in exaile:
status: Confirmed → Fix Committed
reacocard (reacocard)
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.