Should be possible to add a member without leaving a team's main page
Bug #482176 reported by
Guilherme Salgado
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Edwin Grubbs |
Bug Description
We should provide an ajaxy form to add a new team member from the team's main page.
Related branches
lp://staging/~edwin-grubbs/launchpad/bug-482176-add-team-member-ajax-part2
- Martin Albisetti (community): Approve (ui)
- Curtis Hovey (community): Approve (code and js)
- Guilherme Salgado (community): Needs Fixing
- Canonical Launchpad Engineering: Pending (code ui) requested
-
Diff: 962 lines (+399/-202)16 files modifiedlib/canonical/launchpad/icing/style-3-0.css (+3/-0)
lib/canonical/launchpad/icing/style.css (+0/-2)
lib/canonical/launchpad/javascript/code/codereview.js (+7/-6)
lib/canonical/launchpad/javascript/lp/errors.js (+33/-3)
lib/canonical/launchpad/javascript/registry/team.js (+83/-49)
lib/lp/registry/browser/person.py (+33/-21)
lib/lp/registry/browser/tests/mailinglist-views.txt (+5/-4)
lib/lp/registry/interfaces/person.py (+27/-17)
lib/lp/registry/model/person.py (+8/-5)
lib/lp/registry/model/teammembership.py (+2/-10)
lib/lp/registry/stories/team/xx-team-home.txt (+21/-10)
lib/lp/registry/stories/team/xx-team-membership.txt (+13/-0)
lib/lp/registry/templates/team-index.pt (+1/-1)
lib/lp/registry/templates/team-members.pt (+53/-51)
lib/lp/registry/templates/team-portlet-membership.pt (+36/-23)
lib/lp/registry/windmill/tests/test_team_index.py (+74/-0)
lp://staging/~edwin-grubbs/launchpad/bug-482176-add-team-member-ajax-part1
- Gavin Panella (community): Approve (code)
-
Diff: 830 lines (+294/-82)17 files modifiedlib/canonical/launchpad/javascript/bugs/bugtask-index.js (+4/-37)
lib/canonical/launchpad/javascript/code/codereview.js (+9/-1)
lib/canonical/launchpad/javascript/lp/picker.js (+5/-2)
lib/canonical/launchpad/javascript/registry/team.js (+102/-0)
lib/lp/app/templates/base-layout-macros.pt (+2/-0)
lib/lp/bugs/tests/test_bugs_webservice.py (+0/-10)
lib/lp/registry/browser/configure.zcml (+3/-0)
lib/lp/registry/browser/person.py (+43/-12)
lib/lp/registry/browser/tests/teammembership-views.txt (+1/-0)
lib/lp/registry/browser/tests/test_person_webservice.py (+38/-0)
lib/lp/registry/doc/teammembership-email-notification.txt (+6/-0)
lib/lp/registry/doc/teammembership.txt (+39/-2)
lib/lp/registry/interfaces/teammembership.py (+2/-0)
lib/lp/registry/model/person.py (+3/-1)
lib/lp/registry/model/teammembership.py (+4/-5)
lib/lp/registry/templates/team-index.pt (+10/-0)
lib/lp/registry/templates/team-portlet-membership.pt (+23/-12)
lp://staging/~edwin-grubbs/launchpad/bug-482176-add-team-member-ajax-part3
- Aaron Bentley (community): Approve (code)
-
Diff: 1635 lines (+279/-220)57 files modifiedlib/canonical/launchpad/pagetests/standalone/xx-beta-testers-redirection.txt (+1/-1)
lib/lp/answers/doc/person.txt (+2/-2)
lib/lp/bugs/browser/tests/bug-views.txt (+1/-1)
lib/lp/bugs/doc/bugnotification-comment-syncing-team.txt (+1/-1)
lib/lp/bugs/doc/bugnotification-sending.txt (+4/-2)
lib/lp/bugs/doc/bugtask.txt (+2/-1)
lib/lp/bugs/stories/bugwatches/xx-bugwatch-comments.txt (+1/-1)
lib/lp/code/stories/branches/xx-branch-deletion.txt (+1/-1)
lib/lp/code/stories/feeds/xx-revision-atom.txt (+1/-1)
lib/lp/registry/browser/team.py (+5/-3)
lib/lp/registry/browser/tests/peoplemerge-views.txt (+1/-1)
lib/lp/registry/browser/tests/person-views.txt (+1/-1)
lib/lp/registry/browser/tests/product-views.txt (+1/-1)
lib/lp/registry/browser/tests/projectgroupset-views.txt (+1/-1)
lib/lp/registry/browser/tests/team-views.txt (+4/-4)
lib/lp/registry/browser/tests/teammembership-views.txt (+1/-2)
lib/lp/registry/doc/announcement.txt (+1/-1)
lib/lp/registry/doc/commercialsubscription.txt (+1/-1)
lib/lp/registry/doc/mailinglist-email-notification.txt (+8/-5)
lib/lp/registry/doc/mailinglist-subscriptions.txt (+3/-3)
lib/lp/registry/doc/mailinglists.txt (+2/-1)
lib/lp/registry/doc/person-merge.txt (+3/-3)
lib/lp/registry/doc/person.txt (+2/-2)
lib/lp/registry/doc/private-team-visibility.txt (+3/-3)
lib/lp/registry/doc/teammembership-email-notification.txt (+7/-12)
lib/lp/registry/doc/teammembership.txt (+100/-63)
lib/lp/registry/doc/vocabularies.txt (+2/-3)
lib/lp/registry/stories/mailinglists/lifecycle.txt (+1/-1)
lib/lp/registry/stories/mailinglists/subscriptions.txt (+3/-3)
lib/lp/registry/stories/person/xx-admin-person-review.txt (+2/-1)
lib/lp/registry/stories/product/xx-product-edit.txt (+1/-1)
lib/lp/registry/stories/product/xx-productset.txt (+1/-1)
lib/lp/registry/stories/team/xx-team-add-my-teams.txt (+40/-38)
lib/lp/registry/stories/teammembership/20-managing-members.txt (+14/-5)
lib/lp/registry/stories/teammembership/private-team.txt (+1/-1)
lib/lp/registry/stories/teammembership/xx-add-member.txt (+15/-12)
lib/lp/registry/stories/teammembership/xx-expire-subscription.txt (+1/-1)
lib/lp/registry/stories/teammembership/xx-member-renewed-membership.txt (+1/-1)
lib/lp/registry/stories/teammembership/xx-private-membership.txt (+4/-4)
lib/lp/registry/stories/vouchers/xx-voucher-redemption.txt (+2/-1)
lib/lp/registry/stories/webservice/xx-private-membership.txt (+4/-3)
lib/lp/registry/stories/webservice/xx-source-package.txt (+1/-1)
lib/lp/registry/stories/webservice/xx-structuralsubscription.txt (+1/-1)
lib/lp/registry/tests/bug-249185.txt (+5/-4)
lib/lp/registry/tests/test_teammembership.py (+4/-4)
lib/lp/soyuz/browser/tests/archive-views.txt (+2/-2)
lib/lp/soyuz/browser/tests/build-views.txt (+1/-1)
lib/lp/soyuz/doc/archive.txt (+3/-2)
lib/lp/soyuz/doc/archivepermission.txt (+1/-1)
lib/lp/soyuz/doc/archivesubscriber.txt (+2/-1)
lib/lp/soyuz/doc/build-notification.txt (+1/-1)
lib/lp/soyuz/doc/build.txt (+3/-3)
lib/lp/soyuz/doc/distroseriesqueue-dist-upgrader.txt (+1/-1)
lib/lp/soyuz/doc/packageset.txt (+1/-1)
lib/lp/soyuz/stories/ppa/xx-private-ppa-subscription-stories.txt (+1/-1)
lib/lp/soyuz/stories/soyuz/xx-private-builds.txt (+1/-1)
lib/lp/translations/stories/standalone/xx-sourcepackage-export.txt (+1/-1)
Changed in launchpad-registry: | |
importance: | Undecided → High |
Changed in launchpad-registry: | |
milestone: | none → 3.1.11 |
Changed in launchpad-registry: | |
milestone: | 3.1.11 → 3.1.12 |
Changed in launchpad-registry: | |
assignee: | Guilherme Salgado (salgado) → nobody |
Changed in launchpad-registry: | |
status: | In Progress → Triaged |
Changed in launchpad-registry: | |
assignee: | nobody → Edwin Grubbs (edwin-grubbs) |
Changed in launchpad-registry: | |
status: | Triaged → In Progress |
Changed in launchpad-registry: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I've started this during the lazr-js sprint and it only needs some polishing now, but I'm not sure when I'll have time to finish.