Playing should stop when an error occurs

Bug #455701 reported by Ralf Schmelter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
High
Unassigned

Bug Description

When an error occurs during playback, exaile (at least with the normal engine) will just play the next track. In addition an error dialog will pop up. This seems reasonable at the first look, until something like the following happens:
- you have your mp3 files on a separate volume
- the volume is not mounted
- you start a playlist
The result is that every unavailable track is tried to play and you end up with a *lot* of dialogs you have to click away. Since the dialogs are modal, you cannot stop the playing and you even have to click the dialogs away in the 'right' order. Practically this means you have to kill -9 exaile if the playlist contains more than a few 10 tracks.

Since the dialog is modal anyway, I propose to stop playing in case of an error. The attached patch just removes the call to the 'eof_func' in case of an error, which is a bit hacky, but does the job (for the normal engine).

The exaile version used is trunk.

Revision history for this message
Ralf Schmelter (ralf-schmelter) wrote :
reacocard (reacocard)
Changed in exaile:
importance: Undecided → High
milestone: none → 0.3.1
status: New → Confirmed
Revision history for this message
reacocard (reacocard) wrote :

patch committed trunk/2784. Note that this only affects the normal engine, not unified.

Changed in exaile:
status: Confirmed → Fix Committed
reacocard (reacocard)
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.