ObjectNotLocked doing 'bzr log -r 199 path/to/file'
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
Andrew Bennetts | ||
2.0 |
Fix Released
|
High
|
Andrew Bennetts |
Bug Description
This can be seen with a branch of bzr in 2a format:
$ bzr log -r 199 NEWS
bzr: ERROR: bzrlib.
Traceback (most recent call last):
File "/home/
return the_callable(*args, **kwargs)
File "/home/
ret = run(*run_argv)
File "/home/
return self.run(
File "/home/
result = func(*args, **kwargs)
File "/home/
file_list)
File "/home/
kind = _get_kind_
File "/home/
return tree.kind(file_id)
File "/home/
return self._inventory
File "/home/
self.
File "/home/
self.
File "/home/
self._root_node = self._get_
File "/home/
bytes = self._read_
File "/home/
bytes = stream.
File "/home/
orig_keys, ordering, include_
File "/home/
locations = self._index.
File "/home/
self.
File "/home/
raise errors.
ObjectNotLocked: <bzrlib.
bzr 2.1.0dev on python 2.6.2 (Linux-
arguments: ['/home/
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_AU.UTF-8'
plugins:
bisect /home/andrew/
bzrtools /home/andrew/
ec2test /home/andrew/
extmerge /home/andrew/
gtk /home/andrew/
launchpad /home/andrew/
loom /home/andrew/
melddiff /home/andrew/
netrc_
ping /home/andrew/
pqm /home/andrew/
push_and_update /home/andrew/
qbzr /home/andrew/
rebase /home/andrew/
removable /home/andrew/
repokeys /home/andrew/
stats /home/andrew/
subunit_selftest /home/andrew/
svn /home/andrew/
usertest /home/andrew/
*** Bazaar has encountered an internal error. This probably indicates a
bug in Bazaar. You can help us fix it by filing a bug report at
https:/
including this traceback and a description of the problem.
Presumably there's a missing lock_read somewhere.
This was originally reported in <https:/
Related branches
- John A Meinel: Approve
-
Diff: 208 lines5 files modifiedNEWS (+6/-0)
bzrlib/builtins.py (+54/-47)
bzrlib/log.py (+2/-0)
bzrlib/merge_directive.py (+4/-2)
bzrlib/tests/__init__.py (+4/-0)
Changed in bzr: | |
status: | Fix Committed → Fix Released |
Changed in bzr: | |
milestone: | none → 2.1.0b2 |
I have a fix for this, it's pretty shallow. I'll submit it for review for lp:bzr/2.0 shortly.
More interestingly, we *should* have test coverage for this (e.g. blackbox.test_log) but because of the global chk_map page cache the necessary code path is never hit.