Launchpad itself

Series and milestone targeted bugs portlets don't have numbers line up

Bug #434781 reported by Deryck Hodge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Huw Wilkins

Bug Description

The numbers for the bug listings for series and milestone targeted bugs portlets don't align with the filter portlet above them. All the portlets should have the number of bugs aligned vertically.

The reason the numbers all mis-align is because is list is in its own table. Two options exist to fix: 1) make the number column a fixed width for all portlets or 2) don't use tables and float the number to the right.

There are variations on these themes obviously, but I prefer something like #2 personally.

Related branches

lp://staging/~huwshimi/launchpad/sidebar-cleanup
Curtis Hovey (community): Approve (code)
Diff: 711 lines (+162/-177)
16 files modified
lib/canonical/launchpad/icing/css/components/sidebar_portlets.css (+42/-16)
lib/canonical/launchpad/icing/style.css (+0/-17)
lib/lp/answers/browser/questiontarget.py (+1/-1)
lib/lp/app/templates/navigationmenu-related-pages.pt (+1/-1)
lib/lp/blueprints/browser/specificationtarget.py (+1/-1)
lib/lp/bugs/javascript/tests/test_bugtarget_portlet_bugtags.js (+8/-8)
lib/lp/bugs/stories/bug-tags/xx-tags-on-bug-listings-page.txt (+1/-1)
lib/lp/bugs/stories/bugs/xx-portlets-bug-milestones.txt (+4/-2)
lib/lp/bugs/stories/bugs/xx-portlets-bug-series.txt (+16/-8)
lib/lp/bugs/templates/buglisting-default.pt (+1/-1)
lib/lp/bugs/templates/bugtarget-portlet-bugfilters-content.pt (+43/-76)
lib/lp/bugs/templates/bugtarget-portlet-bugtags.pt (+6/-8)
lib/lp/bugs/templates/bugtarget-portlet-tags-content.pt (+7/-8)
lib/lp/bugs/templates/bugtask-portlet-milestonebugs.pt (+9/-12)
lib/lp/bugs/templates/bugtask-portlet-seriesbugs.pt (+9/-12)
lib/lp/bugs/tests/bug.py (+13/-5)
Deryck Hodge (deryck)
tags: added: ui ui-debt
Deryck Hodge (deryck)
Changed in malone:
milestone: 3.1.10 → none
importance: High → Low
Revision history for this message
Curtis Hovey (sinzui) wrote :

This can be fixed by adding <col> rules to the tables in both portlets. Giving the the second column the same value will fix align the tables.

Robert Collins (lifeless)
tags: added: easy
Revision history for this message
Robert Collins (lifeless) wrote :

I think this is a dupe of a presentation glitch I discussed with curtis a couple months back... but I can't find it now. The milestone portlet actually needs to show two levels, because milestones are per-series (though perhaps there is a transition mid-complete there - the schema is ambiguous, but releases are clearly per-series, and milestones become releases...). Given two series s1 and s2 and a milestone 'beta' for each, we actually have:
s1/beta
s2/beta

this could be presented like
beta (aggregate count ?)
  s1 count
  s2 count

Or we could combine the series and milestone portlets (maybe a little faster, definitely less real estate)

s1 count
  beta count
s2 count
  beta count

Huw Wilkins (huwshimi)
Changed in launchpad:
assignee: nobody → Huw Wilkins (huwshimi)
status: Triaged → In Progress
Huw Wilkins (huwshimi)
Changed in launchpad:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.