Preferences with no selection disable preference close button

Bug #430235 reported by Dave Aitken
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Medium
reacocard

Bug Description

Trunk (r 2525) - Ubuntu 9.04

Pretty low priority bug, but noticed the close button in preferences didn't always work. Investigated further, and as soon as the CD plugin's preference pane was selected the close button for the whole preferences window no longer worked, even when another preference pane was chosen afterwards.

Came to the conclusion that this was because no option had been chosen for "Import format" in the plugin (I haven't used exaile to import a CD yet so had not set this myself, and checking the plugin's source it has no default value set), so in exaile's settings this must have had a value of None. This seems to be all that causes the close button to stop working.

To fix: quick fix, just add a default to the CD plugin's import format, but the same bug may come back if future plugins/preference panes are developed that don't give a default.
better? fix: give some sort of feedback as to which option isn't set?

Revision history for this message
Steve Dodier-Lazaro (sidi) wrote : Re: [Bug 430235] [NEW] Preferences with no selection disable preference close button

I think the lack of default option is actually a bug in the CD plugin. Aren
? :)

Revision history for this message
reacocard (reacocard) wrote :

this is sort of a double-bug
1
) the prefs dont handle not-set values well
2) the cd plugin's prefs don't apply a default value, even though the backend does

Changed in exaile:
importance: Undecided → Medium
milestone: none → 0.3.1
reacocard (reacocard)
Changed in exaile:
assignee: nobody → Aren Olson (reacocard)
status: New → Confirmed
Revision history for this message
reacocard (reacocard) wrote :

Doesn't appear to happen in anymore in trunk, if you can still reproduce it please re-open and include detailed instructions on what steps are needed to reproduce it.

Changed in exaile:
status: Confirmed → Fix Committed
reacocard (reacocard)
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.