Preferences with no selection disable preference close button
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Exaile |
Fix Released
|
Medium
|
reacocard |
Bug Description
Trunk (r 2525) - Ubuntu 9.04
Pretty low priority bug, but noticed the close button in preferences didn't always work. Investigated further, and as soon as the CD plugin's preference pane was selected the close button for the whole preferences window no longer worked, even when another preference pane was chosen afterwards.
Came to the conclusion that this was because no option had been chosen for "Import format" in the plugin (I haven't used exaile to import a CD yet so had not set this myself, and checking the plugin's source it has no default value set), so in exaile's settings this must have had a value of None. This seems to be all that causes the close button to stop working.
To fix: quick fix, just add a default to the CD plugin's import format, but the same bug may come back if future plugins/preference panes are developed that don't give a default.
better? fix: give some sort of feedback as to which option isn't set?
Changed in exaile: | |
assignee: | nobody → Aren Olson (reacocard) |
status: | New → Confirmed |
Changed in exaile: | |
status: | Fix Committed → Fix Released |
I think the lack of default option is actually a bug in the CD plugin. Aren
? :)