amazoncovers can't find covers for tracks with multiple 'artist' tags
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Exaile |
Fix Released
|
Low
|
Adam Olsen |
Bug Description
Test case:
1. Enable amazoncovers.
2. Make a track with two artist tags. (Should also work with multiple album tags.) Exaile normally displays such tags as "Tag 1 / Tag 2".
3. Play it.
Result:
Track plays, but the following error happens while trying to search for covers.
File "/exaile/
update_
File "/exaile/
covers = self.find_
File "/exaile/
c = method.
File "/exaile/
(artist, album), limit)
File "/exaile/
ResponseGro
File "/exaile/
return pagedIterator(
File "/exaile/
dom = self.__search(** self.__arguments)
File "/exaile/
return query(buildRequ
File "/exaile/
dom = minidom.
File "/usr/lib/
return expatbuilder.
File "/usr/lib/
result = builder.
File "/usr/lib/
parser.
ExpatError: not well-formed (invalid token): line 1, column 651
Reason:
1. amazoncovers calls Track.get_
2. get_album_tuple calls metadata.j to join multiple tags with the same name.
3. metadata.j joins them using NUL.
4. minidom explodes while parsing Amazon's reply containing the original NUL.
Credits: Steve Dodier reported a symptom of the bug in #exaile.
Changed in exaile: | |
assignee: | nobody → Exaile Bug Day Events (exaile-bugday) |
Changed in exaile: | |
milestone: | none → 0.3.0.1 |
Changed in exaile: | |
assignee: | Exaile Bug Day Events (exaile-bugday) → nobody |
Changed in exaile: | |
status: | Fix Committed → Fix Released |
retargeting to 0.3.0.2