Split IBranch into separate interfaces based on required permissions
Bug #399547 reported by
Jonathan Lange
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Tim Penhey | ||
Bug Description
Currently there's one big IBranch interface and we decide which methods & attributes require which permissions using the ZCML file.
This is awkward, and leads to unexpected errors when we forget to update the ZCML. Instead, let's just have interfaces like IBranchEdit, IBranchView or what have you, and define the permissions in terms of those.
Related branches
lp://staging/~thumper/launchpad/ibranch-interface-smashing
- Paul Hummer (community): Approve (code)
-
Diff: 750 lines (+259/-335)3 files modifiedlib/lp/code/configure.zcml (+17/-117)
lib/lp/code/interfaces/branch.py (+239/-216)
lib/lp/code/model/branch.py (+3/-2)
| Changed in launchpad-code: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Tim Penhey (thumper) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #1 |
| Changed in launchpad-code: | |
| milestone: | none → 10.08 |
| tags: | added: qa-needstesting |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-untestable removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r11203 <http://