qbittorrent crashes on start due to malformated line in IP filter file

Bug #398458 reported by Maxime Teissier
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qBittorrent
Fix Released
Low
Christophe Dumez

Bug Description

Qbittorrent used to work perfectly on my system (Ubuntu 9.04)
Today it refused to start, probably since one of its components update.
installed:
libtorrent-rasterbar2 version 0.14.2-2ubuntu1
qbittorrent version 1.3.3-1

The splash windows appears for a short moment and disappears.

If started from a console, the following text is put out:
----------------------------------------------------------------------------------------

max@PCMAX:~$ qbittorrent

*************************************************************
Catching SIGSEGV, please report a bug at http://bug.qbittorrent.org
and provide the following backtrace:
stack trace:
  [0xb7f29400]
  /usr/lib/libQtCore.so.4 : QLocalePrivate::numberToCLocale(QString const&, QLocalePrivate::GroupSeparatorMode, QVarLengthArray<char, 256>*) const+0x20 [0xb6e906c0]
  /usr/lib/libQtCore.so.4 : QLocalePrivate::stringToLongLong(QString const&, int, bool*, QLocalePrivate::GroupSeparatorMode) const+0x7b [0xb6e90f0b]
  /usr/lib/libQtCore.so.4 : QString::toLongLong(bool*, int) const+0x55 [0xb6eaa2c5]
  /usr/lib/libQtCore.so.4 : QString::toInt(bool*, int) const+0x33 [0xb6eaa3c3]
  qbittorrent : FilterParserThread::parseDATFilterFile(QString)+0x7fc [0x818933c]
  qbittorrent : FilterParserThread::run()+0x76 [0x818a606]
  /usr/lib/libQtCore.so.4 [0xb6e6496e]
  /lib/tls/i686/cmov/libpthread.so.0 [0xb7ba64ff]
  /lib/tls/i686/cmov/libc.so.6 : clone()+0x5e [0xb6c6b49e]

max@PCMAX:~$
---------------------------------------------------------------------------------------

Revision history for this message
Christophe Dumez (hydr0g3n) wrote :

I'll have a look at the faulty function. In the meantime, please stop using IP filter:
* edit file at ~/.config/qBittorrent/qBittorrent.conf
* remove line starting with "IPFilter\File="
* save file, and run qBittorrent.

Are you, by any chance, using 64bits? There was a bug in IPfilter code on 64bits architecture in v1.3.3 (which was fixed since then in v1.3.4).

If you could post you dat file here, I could test it too.

Changed in qbittorrent:
assignee: nobody → Christophe Dumez (hydr0g3n)
status: New → Confirmed
Revision history for this message
Christophe Dumez (hydr0g3n) wrote :

Il semble que vous soyez français :)

Je viens de jeter un coup d'oeil à la fonction et il cela ressemble beaucoup au bug sur 64bits que j'ai corrigé depuis dans la v1.3.4. Le patch a été appliqué au package de v1.3.3-2 de Ubuntu.

Concernant la version de votre paquet de qBittorrent: 1.3.3-1
Cela correspond au paquet qui ne comprend pas le patch pour 64bits.

cf. rapport de bug suivant:
https://bugs.launchpad.net/qbittorrent/+bug/371283

Le probleme est que je ne sais pas si la v1.3.3-2 a été ajouté a Ubuntu v9.04 ou pas. Je sais que le probleme est corrigé dans la v9.10 en tout cas.

Revision history for this message
Maxime Teissier (maxime-teissier) wrote :

Desactiver l'IP filter resoud le probleme: QBitTorrent demarre correctement.

je peux par contre utiliser Moblock pour le filtrage d'IP, donc pour moi le probleme est resolu!

je suis sur une machine 64-bit (AMD64 double coeur) mais j'execute une version 32-bit d'Ubuntu. Donc soit le probleme affecte aussi les versions 32-bits, soit c'est un probleme different...

Je resterais sur ubuntu 9.04 jusqu'a la release officielle de la 9.10 en octobre.

ci-joint mon ipfilter.dat - je ne sais plus trop d'ou il vient...

Merci pour la reponse rapide et n'hesitez pas si vous avez d'autres questions...

Revision history for this message
Christophe Dumez (hydr0g3n) wrote :

I tried your filter file and I noticed that a malformated IP address caused qBittorrent to crash. I made the parser more robust to avoid this kind of problem.

Changed in qbittorrent:
importance: Undecided → Low
milestone: none → 1.4.0
status: Confirmed → Fix Committed
summary: - qbittorrent refuse to start
+ qbittorrent crashes on start due to malformated line in IP filter file
Revision history for this message
Christophe Dumez (hydr0g3n) wrote :

v1.4.0 is out.

Changed in qbittorrent:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.