Launchpad itself

milestone deactivation warning when milestone autocreated is alarming

Bug #386584 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Curtis Hovey
Launchpad itself 10.01

Bug Description

When registering a release, and creating a milestone inline on the
format, you get a warning like: "The 0.0.1 milestone for this project
release was deactivated so that bugs and blueprints cannot be associated
with this release."

This warning is unnecessary and a little alarming (it has a /!\ marker)
as the milestone is only being created for the launchpad machinery of
using it to track the release.

-Rob

 affects launchpad

--

Tags: lp-registry

Related branches

lp://staging/~sinzui/launchpad/release-love
Eleanor Berger (community): Approve
Diff: 262 lines (+73/-24)
10 files modified
database/schema/security.cfg (+3/-0)
lib/canonical/launchpad/subscribers/karma.py (+8/-2)
lib/lp/bugs/doc/malone-karma.txt (+32/-1)
lib/lp/registry/browser/productrelease.py (+0/-5)
lib/lp/registry/browser/tests/productrelease-views.txt (+0/-6)
lib/lp/registry/doc/milestone.txt (+23/-0)
lib/lp/registry/model/milestone.py (+6/-2)
lib/lp/registry/stories/productrelease/xx-productrelease-basics.txt (+0/-6)
lib/lp/registry/stories/productrelease/xx-productrelease-view.txt (+0/-1)
lib/lp/registry/templates/milestone-index.pt (+1/-1)
Diogo Matsubara (matsubara)
affects: launchpad → launchpad-registry
Revision history for this message
Curtis Hovey (sinzui) wrote :

Agreed. The user does not care in this case.

Changed in launchpad-registry:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Curtis Hovey (sinzui) wrote :

The milestone is created in a separate async request. The view that creates the release does not know the milestone was just created. When the release is created it can guess that a milestone that is less than 30 minutes old does not require a notification that it is closed.

We might consider the notification to be a device to deal with a bad design. If the milestone/release page clear stated that
    Bugs *cannot* be targeted to the milestone (!)
or
    Bugs *can* be targeted to the milestone (!)
We might not ever need to say that the milestone is active.

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 386584] Re: milestone deactivation warning when milestone autocreated is alarming

On Fri, 2009-06-19 at 21:16 +0000, Curtis Hovey wrote:

> We might consider the notification to be a device to deal with a bad design. If the milestone/release page clear stated that
> Bugs *cannot* be targeted to the milestone (!)
> or
> Bugs *can* be targeted to the milestone (!)
> We might not ever need to say that the milestone is active.

This is plausible to me.

-Rob

--

Revision history for this message
Curtis Hovey (sinzui) wrote :

I think I have a simple solution. The active state control enables targeting. If nothing is targeted to a milestone, there is no evidence that the milestone will be used for targeting. There is no need for a warning in this case.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Since the 3.0 redesign, the milestones active state has had a clear and prominent message on the page. We do not need the warning since 1) the form for creating the release explained the issue, and 2) the user can easilly fix the issue. I will remove the warning.

Changed in launchpad-registry:
assignee: nobody → Curtis Hovey (sinzui)
status: Triaged → In Progress
milestone: none → 10.01
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fixed in db-devel r8923.

Changed in launchpad-registry:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.