Build icons inconsistent and squashed

Bug #378141 reported by William Grant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Michael Nelson

Bug Description

Three build-related icons (processing, build-failed and build-success-publishing) were recently replaced. 'processing' doesn't seem to be used anywhere, but 'build-failed' is used as a build status, and 'build-success-publishing' as a source package build/publishing status.

The other icons for build statuses are of a completely different style, and are 14x14. The new build-failed is 16x14, so is now squashed as well as inconsistent with the rest.

Of the icons now used as combined build/publishing status indicators, one is in the style of the old build icons (is 'processing' meant to replace this?), one is in the new build icon style, one is a tick (reasonable), and one is a cross (should 'build-failed' replace this?).

The inconsistency looks pretty bad.

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Thanks William. Yes, some of the new icons were added with different names. I updated the build failed icon (bug 376940), but didn't realise the build-building had been renamed to build-processing.

So yes, the new build-processing icon should replace the old one (build-building - I'll do that now). I'll check the pixel sizes and adjust the tales filter to set the correct pixel sizes for each icon (unless Martin wants to resize them?).

The cross is currently used only for the combined source-package build/publishing status (in the same way that the tick is), that is, to represent, "there were problems/failures with the builds for this source package". I don't think this should be replaced by build-failed, as it might be unsuccessful for other reasons, not just build failure? Let me know if you think otherwise...

Changed in soyuz:
assignee: nobody → Michael Nelson (michael.nelson)
importance: Undecided → Medium
milestone: none → 2.2.5
status: New → In Progress
tags: added: trivial ui
Revision history for this message
William Grant (wgrant) wrote :

I agree with you about the cross; I forgot there were a couple of additional terminal failure states for builds.

Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in devel r8485.

Changed in soyuz:
status: In Progress → Fix Committed
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.