InterfaceError: connection already closed should be converted into DisconnectionError

Bug #374909 reported by Francis J. Lacoste
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Storm
Fix Released
High
James Henstridge

Bug Description

Like bug 360846 showed it's possible for disconnection error to go unnoticed and leave the connection in a irrecuperable state. When the connection is in this state, psycopg2 will raise an InterfaceError: connection already closed error, these should be recognized as disconnection error and converted to the appropriate exception.

Related branches

Revision history for this message
James Henstridge (jamesh) wrote :

This is affecting U1 too (the Django integration bypasses Storm's disconnection checking, so it is possible for this error to occur).

Changed in storm:
assignee: nobody → James Henstridge (jamesh)
importance: Undecided → High
status: New → Triaged
milestone: none → 0.15
Changed in storm:
status: Triaged → In Progress
Revision history for this message
Thomas Herve (therve) wrote :

This bug is fixed now?

Revision history for this message
James Henstridge (jamesh) wrote :

Fix merged in r308.

Changed in storm:
status: In Progress → Fix Committed
Changed in storm:
status: Fix Committed → Triaged
Revision history for this message
Guilherme Salgado (salgado) wrote :

Connection.rollback() doesn't consider InterfaceError a form of disconnection error as it was meant to do.
I have a fix for that at lp:~salgado/storm/bug-374909, and I'd appreciate if someone could have a look.

Revision history for this message
James Henstridge (jamesh) wrote :

That branch has also been reviewed and merged now as r319.

Changed in storm:
status: Triaged → Fix Committed
Jamu Kakar (jkakar)
Changed in storm:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.