Launchpad itself

warts preventing easy testing of git imports in staging

Bug #364373 reported by Michael Hudson-Doyle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Michael Hudson-Doyle
Launchpad itself 2.2.4

Bug Description

I'm testing git imports on staging and so far have found two small problems:

1. effective_update_interval doesn't know about git imports
2. git_repo_url is not mentioned in the ZCML for ICodeImport.

I can hack around both of these for now, and when I've managed to get a test to complete I'll whip up a branch to fix these issues.

Tags: lp-code
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

3. we end up passing a unicode string to spawnProcess for the git url.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

4. it needs the pysqlite2 module with python2.4

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

5. running the worker by hand with python2.5 seems to complete successfully, but it's not clear where the imported branch has gone

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

5. was a pebkac

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

for 4, launchpad-dependencies has been updated and an RT filed about it.

Revision history for this message
Tim Penhey (thumper) wrote :

How much effort is it to fix 1-3? I see that the RT was fixed for the staging import machines.

Can we try to get the YUI git import working as one of the first tests?

Revision history for this message
Paul Hummer (rockstar) wrote :

#2 was done in my git-import-ui branch (which is approved but has been held off temporarily because of these things), so it wasn't difficult. I imagine that #1 is also not going to be hard, and I'm unclear as to the context of #3, so I'll need to investigate that one, or Michael can comment on it.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Oh it's all fairly easy. If I wasn't chasing bzr 1.14 issues I'd be done already I expect...

Paul Hummer (rockstar)
Changed in launchpad-bazaar:
assignee: nobody → Michael Hudson (mwhudson)
importance: Undecided → High
milestone: none → 2.2.4
status: New → In Progress
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

This was released in 2.2.4.

Changed in launchpad-code:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.