hardcoded paths
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Entertainer Media Center |
Fix Released
|
Low
|
Matt Layman |
Bug Description
I'm playing with entertainer from repsitory on openbsd and found some problems/bugs:
setup.py:
target = os.path.
better use:
target = os.path.
but I think the whole install class is the wrong approach, installing manpages and updating gtk icon cache should be done by package tools like rpm/deb/...
utils/configura
better use this:
# Hardcoded path for a package install
'package' : os.path.
utils/configura
CFG_DIR = os.path.
better use standard module for this:
import user
CFG_DIR = os.path.
in general: avoid absolute paths with "/" - use os.path.join always.
Related branches
Changed in entertainer: | |
status: | In Progress → Fix Committed |
Changed in entertainer: | |
status: | Fix Committed → Fix Released |
umaxx, thanks for the report. I think that you raise a valid issue and paths should sys.prefix.
I do disagree with you about the installation of manpages and icon cache. Entertainer is trying to be a distro agnostic upstream. In order to be that, `python setup.py install` must do the right thing and provide the full installation for a user. Without the steps we've taken, it would not be possible to install properly from source.
I believe our Debian package removes this code in the diff.gz and lets the packaging system do the work. I think that this is the right approach to support specific distros and those who just want the source.