List of 'details that will be sent' to RP is incomplete
Bug #341754 reported by
James Troup
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical SSO provider |
Fix Released
|
Low
|
Anthony Lenton | ||
Bug Description
When I login to an LP-OpenID enabled website, login.launchpad.net gives me a list of 'details that will be sent [to the RP]'. However, that list is missing, at least, team information for RPs where we send it.
Testcase added to ISD_142
Related branches
lp://staging/~canonical-isd-hackers/canonical-identity-provider/missing-details
- David Owen (community): Approve
-
Diff: 138 lines (+37/-9)3 files modifiedidentityprovider/templates/decide.html (+4/-1)
identityprovider/tests/test_views_server.py (+21/-2)
identityprovider/views/server.py (+12/-6)
| Changed in launchpad-foundations: | |
| importance: | Undecided → Low |
| status: | New → Triaged |
| Changed in canonical-identity-provider: | |
| milestone: | none → 2.7.0 |
| tags: | added: 1ps |
| tags: |
added: 1sp removed: 1ps |
| Changed in canonical-identity-provider: | |
| assignee: | nobody → Łukasz Czyżykowski (lukasz-czyzykowski) |
| status: | Triaged → In Progress |
| Changed in canonical-identity-provider: | |
| assignee: | Łukasz Czyżykowski (lukasz-czyzykowski) → nobody |
| Changed in canonical-identity-provider: | |
| assignee: | nobody → Anthony Lenton (elachuni) |
| Changed in canonical-identity-provider: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Anthony Lenton (elachuni) wrote | #1 |
Revision history for this message
| Anthony Lenton (elachuni) wrote | #2 |
Revision history for this message
| Dave Morley (davmor2) wrote | #3 |
| Changed in canonical-isd-qa: | |
| status: | New → Confirmed |
| assignee: | nobody → Dave Morley (davmor2) |
| description: | updated |
Revision history for this message
| Dave Morley (davmor2) wrote | #4 |
| Changed in canonical-isd-qa: | |
| status: | Confirmed → Fix Committed |
Revision history for this message
| Dave Morley (davmor2) wrote | #5 |
| Changed in canonical-isd-qa: | |
| status: | Fix Committed → Fix Released |
| Changed in canonical-isd-qa: | |
| milestone: | none → canonical-identity-provider+2.7.0 |
| Changed in canonical-identity-provider: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Notes to QA:
You can verify this is working correctly with the test fixture installed, by following these steps:
1- Add an OpenIDRPConfig for the embedded consumer (or check that there is one)
2- Ensure that the OpenIDRPConfig for the embedded consumer has the "can query any team" checkbox selected
3- Using the embedded consumer request teams data (last checkbox before the submit button)
4- Sign in as <email address hidden>
You should see the "myteam" membership is sent back to the consumer.