Bazaar

test_walkdirs_os_error not robust

Bug #341648 reported by James Westby
2
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Undecided
Vincent Ladeuil
Bazaar 1.14rc1

Bug Description

I get:

FAIL: test_osutils.TestWalkDirs.test_walkdirs_os_error
    not equal:
a = "[Errno 13] Permission denied: './test-unreadable'"
b = "[Errno 13] chdir: Permission denied: './test-unreadable'"

perhaps because of a different python or glibc or similar.

Thanks,

James

Revision history for this message
Vincent Ladeuil (vila) wrote :

This is triggered as soon as the C extensions are not built.
Anyway, testing e.errno should achieve the same result while being less fragile.

Changed in bzr:
assignee: nobody → vila
status: New → In Progress
Vincent Ladeuil (vila)
Changed in bzr:
milestone: none → 1.14rc1
Revision history for this message
Martin Pool (mbp) wrote :

The point of this test is to check the string representation includes the filename, which was bug 338653. So please make sure that's still in there after this change.

Revision history for this message
Martin Pool (mbp) wrote :

but you're right that the message is inconsistent about including 'chdir' or not depending on whether the extensions are up to date, so the test should probably match using a regexp or something.

Revision history for this message
Vincent Ladeuil (vila) wrote :

Sorry about that, fix submitted to pqm including an explicit check that the filename appears in the stringified exception.

Vincent Ladeuil (vila)
Changed in bzr:
status: In Progress → Fix Committed
Vincent Ladeuil (vila)
Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.