Strip leading slashes in tarball paths
Bug #338234 reported by
Jeroen T. Vermeulen
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Henning Eggers | ||
Bug Description
When the import queue code unpacks a tarball, it sometimes gets file paths with leading slashes. Those can confuse the auto-approver because the slash can introduce a meaningless difference between POTemplate/POFile paths and upload paths. As a result, uploads may fail to be approved. This is better fixed in the upload code though, as a one-time normalization, than in the approver.
After we fix this, further rejoicing could be brought about by stripping leading slashes from the 10k POFile paths that have them.
Related branches
lp://staging/~henninge/launchpad/devel-bug-338234-leading-slashes
- Brad Crittenden (community): Approve (code)
-
Diff: 407 lines (+196/-107)7 files modifiedlib/lp/services/doc/tarfile_helpers.txt (+6/-6)
lib/lp/services/tarfile_helpers.py (+108/-0)
lib/lp/translations/doc/translationimportqueue.txt (+1/-2)
lib/lp/translations/model/translationimportqueue.py (+1/-1)
lib/lp/translations/scripts/language_pack.py (+1/-1)
lib/lp/translations/tests/test_translationimportqueue.py (+78/-0)
lib/lp/translations/utilities/translation_export.py (+1/-97)
| Changed in rosetta: | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| tags: | added: import-queue trivial |
Revision history for this message
| Adi Roiban (adiroiban) wrote | #1 |
| Changed in rosetta: | |
| assignee: | nobody → Adi Roiban (adiroiban) |
| Changed in launchpad: | |
| assignee: | Adi Roiban (adiroiban) → Henning Eggers (henninge) |
| status: | Triaged → In Progress |
| tags: | added: bugjam2010 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Данило Шеган (danilo) wrote | #3 |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| Changed in launchpad: | |
| milestone: | none → 11.01 |
To post a comment you must log in.
I guess I can do this as an exercise for hacking on ImportQueue