Allow deleting karmas
Bug #336430 reported by
Stefano Rivera
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ibid |
Fix Released
|
Medium
|
Stefano Rivera |
Bug Description
Query: ibid++
Query: ibid--
Query: karmaladder
Response: 0: ibid (0)
Query: karma ibid
Response: ibid has karma of 0
Silly people karma silly things, allow admins to remove useless karmas.
Related branches
lp://staging/~stefanor/ibid/karma-336430
- Jonathan Hitchcock: Approve
- Michael Gorven: Approve
- Diff: None lines
Changed in ibid: | |
importance: | Undecided → Medium |
milestone: | none → 0.2 |
status: | New → Confirmed |
Changed in ibid: | |
assignee: | nobody → stefanor |
status: | Confirmed → In Progress |
Changed in ibid: | |
milestone: | 0.2 → 0.1 |
status: | In Progress → Fix Released |
To post a comment you must log in.
The karma plugin also keeps track of 'changes' - i.e. the number of times a karma has gone up and down altogether, so you can see what the most contentious thing is, perhaps. If something went all the way up to 100 and then back down to zero, we'd probably want to keep the entry around, but if it went up one, and then got removed again, we should toss it.
In other words, if the new karma is zero, and the 'changes' value is four or less (?), we should remove the entry from the database, yes?
Another point, from the Get processor in the karma plugin:
karma = session.query(Karma).filter(func.lower(Karma.subject)==subject.lower()).first()
event.addresponse(u"%s has neutral karma" % subject)
if not karma:
Note that a karma of zero in this case is not the same as 'neutral karma'. I could even argue that having a karma of zero (i.e. your 'changes' is more than four, but your 'karma' is zero) is 'neutral karma', but not having any karma entry should be called something else ("nobody cares, dude").