Olive

toolbars lack tooltips, no buttons are marked as "important"

Bug #333876 reported by Dylan McCall
30
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Olive
Triaged
Medium
Unassigned

Bug Description

I have set GTK's default toolbar style to be "Text beside items". With this style, the toolbar items marked as Important have text labels beside them and everything else is just an icon. This style is attractive and saves lots of space!

However, Olive doesn't do the necessary steps to work well in this case. No toolbar items are labelled as important, and there are absolutely no tooltips for them so it is impossible for a user who has changed his toolbar style to understand how to use Olive's toolbar. This happens in the main window and with the Reload button in the log window.

Note that this probably creates a few serious usability (accessibility?) issues other than just a matter of prettiness, as well.

Tags: olive toolbar

Related branches

lp://staging/~ingolemo/bzr-gtk/fix-for-LP333876
Jasper Groenewegen (community): Approve
Diff: 57 lines (+9/-0)
1 file modified
olive/window.py (+9/-0)
lp://staging/bzr-gtk/gtk2
Revision history for this message
gsmx (gsmx) wrote :

I have the same behaviour, in both Jaunty and Intrepid, so i can confirm this and find it personally very annoying, cause i'm new to the whole version control/ bazaar thing and don't know all its functions.

Changed in bzr-gtk:
status: New → Confirmed
Revision history for this message
Ingolemo (ingolemo) wrote :

This seemed like an easy issue to fix, so I've had a stab at it.

I'm a little inexperienced when it comes to this kind of thing. Thus I'm unsure of the protocol that I should use to go about submitting patches. So I'm going to put it here and hope that somebody can point me in the right direction.

Jelmer Vernooij (jelmer)
Changed in bzr-gtk:
importance: Undecided → Medium
status: Confirmed → Triaged
tags: added: olive toolbar
Revision history for this message
Jasper Groenewegen (colbrac) wrote :

Hi Ingolemo, sorry you patch lingered for a while. It looks ok to me!

One thing is that I feel the description of the update button could be improved. You now write "Update the current branch" but what actually happens is that the files in the working tree are updated according to the info found in the branch (which can be the .bzr folder or in the case of a checkout from a remote branch from the remote .bzr folder). Changes made to the files which were not yet committed are kept and can be either discarded with Revert or committed.

So maybe a better description is "Update the files from the branch" or even "Update the working tree" as both lines are only understandable to a user who at least understands the difference between the working tree (the actual files under version control) and the branch (the info/files in the (remote) .bzr folder).

Regards,

Jasper

Revision history for this message
Ingolemo (ingolemo) wrote :

I assume you want me to resubmit. How about this one? I lost the original branch, so I had to rebranch and recommit the changes in order to make it.

Revision history for this message
Jasper Groenewegen (colbrac) wrote :

Seems ok. Now I yesterday learned how to properly submit patches against bzr-gtk. Here is what you do.
- First make sure launchpad knows a ssh key of you
- In the branch issue a 'bzr push lp:~ingolemo/bzr-gtk/fix-for-LP333876' (where the final bit can be whatever you like)
- If this goes OK you can see the branch in your own list of branches and somewhere halfway you can click on 'Propose for merging' where it should automatically pick the right branch to merge to (lp:bzr-gtk).

If there are issues somewhere along the road, do let me know :)

Jelmer Vernooij (jelmer)
affects: bzr-gtk → olive
Revision history for this message
galactic-warrior (galactic-warrior) wrote :

Yes - it is annoying not to have any toolbat tips when hovering over a button!

Revision history for this message
galactic-warrior (galactic-warrior) wrote :

toolbar I mean!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.