DC++

DC++ downloads with segmented downloading after disabling

Bug #317339 reported by PsychicSword
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ApexDC++
In Progress
Undecided
Unassigned
DC++
Fix Released
Low
Unassigned
StrongDC++
Fix Committed
Undecided
Unassigned

Bug Description

I have tested DC++ 0.706-0.7091(by attempting to download from someone with CzDC with the segmented downloading blocked) In all versions I fully disabled segmented downloading by unchecking File>Settings>Advanced>Enable segmented downloads. In all versions it gets blocked because of segmented downloading. A friend of mine noticed a pattern that it happens when a 700.1mb file(as an example) gets downloaded it will round it down to a 700mb file and download the last 0.1mb as a separate segment. He fixed the problem is his compilation by forcing it to always round up.

Revision history for this message
PsychicSword (psychicsword) wrote :
Revision history for this message
PsychicSword (psychicsword) wrote :
Revision history for this message
poy (poy) wrote :

can you make a patch instead?

Big Muscle (bigmuscle)
Changed in strongdc:
status: New → Fix Committed
Revision history for this message
PsychicSword (psychicsword) wrote :
poy (poy)
Changed in dcplusplus:
status: New → Fix Committed
Revision history for this message
PsychicSword (psychicsword) wrote :
Revision history for this message
Toast (swetoast-deactivatedaccount) wrote :

This is more up to the hubowner to not allow bad clients by using client checks since CZDC doesnt allow segmented for some reason its more or less a client blocker and there for should be banned so use +report in that hub instead of trying to change clients.

Revision history for this message
PsychicSword (psychicsword) wrote :

there is a problem with the code in the client that causes the feature to remain on even when turned off. The part about czdc is just how I proved the problem existed before I looked in the code.

Revision history for this message
Toast (swetoast-deactivatedaccount) wrote :

Then boot the users with it simple better then to change protocol specs

Revision history for this message
PsychicSword (psychicsword) wrote :

Since DC++ 0.706 there was supposed to be a way of fully turning off segmented downloading, but there was a bug in the code that prevented it from doing so in some cases. This is not a new feature, this is a bug with an existing feature.

Revision history for this message
Gubbins (frunkzuppa7) wrote :

Could someone please tell me. Why segmented downloads in a DC-client ?
I admit, it could come in handy if u play around at some pubby hubs for downloading big unpacked iso's.
But not if u stay around at some small private hubs for downloading rar's

Revision history for this message
Twilight2013 (twilight2013) wrote :

Gubbins, here's the answer to your question with link & read: http://dcpp.wordpress.com/2007/10/07/segmented-downloads-and-multi-source

Revision history for this message
Gubbins (frunkzuppa7) wrote :

Twilight2013, thanks for the description ! But let me put it this way, do we really need segmented downloads in a DC-client ?

Revision history for this message
eMTee (realprogger) wrote :

This is a bugtracker not a discussion forum so please use the Answers section for discussing this. Thanks.

Revision history for this message
Twilight2013 (twilight2013) wrote :

I know this is a bugtracker & all, but I want to make my point clear. If a private hub doesn't accept segmented downloads, then the hubowner wants to dwell & live in the past. Try going to hubs, both private & public, that accepts the latest version of DC++. Plain & simple. Case closed!

Revision history for this message
Big Muscle (bigmuscle) wrote :

The implemented patch is invalid. It throws TTH inconsistency on resume when segmented downloads are off. Also there could be problem when there's file partially downloaded with S/D and then S/D are switched off.

Changed in dcplusplus:
status: Fix Committed → In Progress
Changed in strongdc:
status: Fix Committed → In Progress
Crise / MW (markuwil)
Changed in apexdc:
status: New → Fix Committed
status: Fix Committed → In Progress
Revision history for this message
Jacek Sieka (arnetheduck) wrote :

untested patch committed (yet another option I never use...), reopen if it doesn't work...

Changed in dcplusplus:
importance: Undecided → Low
status: In Progress → Fix Committed
Big Muscle (bigmuscle)
Changed in strongdc:
status: In Progress → Fix Committed
eMTee (realprogger)
Changed in dcplusplus:
status: Fix Committed → Fix Released
adrian_007 (adrian-007)
Changed in rsxplusplus:
assignee: nobody → adrian_007 (adrian-007)
importance: Undecided → Low
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.