Elisa doesn't start after upgrade on 0.5.20/21

Can you please run elisa with the following command in a terminal and attach here the output?

    ELISA_DEBUG=plugin_registry:5,*manager:5 elisa

I have this problem on my Hardy box as well.

cassidy@cass-wks:~$ ELISA_DEBUG=plugin_registry:5,*manager:5 elisa
Launcher core version: 0.5.21
Current core version: 0.5.21
/usr/lib/python2.5/site-packages/elisa/core/utils/classinit.py:34: UserWarning: ClassInitMeta class is deprecated
  warn("ClassInitMeta class is deprecated")
Traceback (most recent call last):
  File "/usr/bin/elisa", line 8, in <module>
    load_entry_point('elisa==0.5.21', 'gui_scripts', 'elisa')()
  File "/usr/lib/python2.5/site-packages/elisa/core/launcher.py", line 363, in main
    Launcher().main(sys.argv)
  File "/usr/lib/python2.5/site-packages/elisa/core/launcher.py", line 71, in main
    return self.main_after_voodoo(argv)
  File "/usr/lib/python2.5/site-packages/elisa/core/launcher.py", line 202, in main_after_voodoo
    self.run_application()
  File "/usr/lib/python2.5/site-packages/elisa/core/launcher.py", line 335, in run_application
    application = Application(self.options)
  File "/usr/lib/python2.5/site-packages/elisa/core/application.py", line 276, in __init__
    super(Application, self).__init__(options, plugin_directories)
  File "/usr/lib/python2.5/site-packages/elisa/core/application.py", line 168, in __init__
    self.plugin_registry = self._create_plugin_registry(plugin_directories)
  File "/usr/lib/python2.5/site-packages/elisa/core/application.py", line 175, in _create_plugin_registry
    plugin_registry.load_plugins(disabled_plugins)
  File "/usr/lib/python2.5/site-packages/elisa/core/plugin_registry.py", line 333, in load_plugins
    self.load_plugin(dist)
  File "/usr/lib/python2.5/site-packages/elisa/core/plugin_registry.py", line 378, in load_plugin
    toplevel_directory = get_plugin_toplevel_directory(plugin)
  File "/usr/lib/python2.5/site-packages/elisa/core/plugin_registry.py", line 89, in get_plugin_toplevel_directory
    assert dist.project_name.startswith('elisa-plugin-')
AssertionError

It seems that the plugin registry is trying to load an egg that is not an elisa plugin. We could patch the plugin registry to just skip such an egg instead of failing, but it remains interesting to understand what egg is causing this problem.

Can you please patch /usr/lib/python2.5/site-packages/elisa/core/plugin_registry.py and set a break point just before the assertion that fails and attach here information on the culprit dist?

I added a print dist.project_name before the assertion and the culprit seems to be "elisa-plugins-bad".

Interesting. I have no clue how you would end up with an elisa-plugins-bad egg. I'm going to need you to investigate a bit more to understand where that faulty distribution comes from.
Can you just slightly modify your print statement to print dist.__dict__ instead of dist.project_name and attach the output? That will give us more information on the distribution.

{'project_name': 'elisa-plugins-bad', 'precedence': -1, '_key': 'elisa-plugins-bad', '_version': '0.3.4.rc2', 'platform': None, '_Distribution__dep_map': {None: []}, 'location': '/usr/lib/python2.5/site-packages', 'py_version': '2.5', '_parsed_version': ('00000000', '00000003', '00000004', '*c', '00000002', '*final'), '_provider': <pkg_resources.PathMetadata instance at 0x8c5456c>}

It looks like you have some leftovers from a very old version of Elisa (0.3.4rc2, dates back from February). The way we install plugin bundles has changed between 0.3.x and 0.5.x.

The easy and quick fix is to remove everything related to elisa in /usr/lib/python2.5/site-packages and then reinstall it from the PPA packages:

    $ sudo aptitude remove elisa
    $ sudo rm -rf /usr/lib/python2.5/site-packages/elisa*
    $ sudo aptitude install elisa

I'll write a patch that will make elisa less strict and instead of failing will just skip unknown plugins/bundles.

Then something is wrong in Debian packages as these files should have been automatically removed.

Could it be that you manually installed them from the tarballs back in the days?

Not that I remember. Which files shouldn't be there anymore? So I can look for the package providing them.

Files matching the following should definitely not be there any longer:

    /usr/lib/python2.5/site-packages/elisa-plugins-{good,bad,ugly}*

Humm seems you were right. These files were not provided by any package. I removed them and things works fine now.

Anyway, this bug has to stay open until the assertion is fixed.

I submitted yesterday a merge request that fixes it (https://elisa.fluendo.com/quality/review/request/%<email address hidden>%3E), it should be fixed in Elisa 0.5.23.