OOPS in MailingListAPIView

With confirmation from Gustavo, it seems like the .union() call in getSenderAddresses() is ignoring the prejoins. Recommendation is to rewrite the method to use native Storm queries.

Er, the .union() call in the SQLObject compatibility layer.

I tried and failed to rewrite the queries using the storm native api. The .union() call defeated me. On Francis's suggestion, I used the old SQLObject API and changed the union call to:

team_members.union(approved_posters).prejoin(['person'])

while this doesn't fail, it also doesn't help reduce the query count, as verified by custom tracers that counted the total number of queries.

Given that I've spent a day on this and failed, Francis suggests we leave it until we get OOPSes on production, so I'm bumping down the importance and removing the milestone.

Tom Haddon brought to my attention today that we're generating 6gb/day OOPS reports in the internal xmlrpc server (arsenic). I've updated oops-tools to include the internal xmlrpc OOPSes. We can see by OOPS-969XMLP1805 that this bug occurs on production

Moral of the story: when you see something OOPS on staging, it means it's serious, even if you don't know what exactly is going on!