wrong album-cover displayed

Bug #253656 reported by Gunnar Holmberg
6
Affects Status Importance Assigned to Milestone
Moovida
Fix Released
High
Philippe Normand

Bug Description

Elisa is displaying the wrong album covers for some albums. This is mainly due to the fact that the amazon is queried only with album-name - no artist-name. Just fetching the artist name from the database and query amazon with both artist-album should solve a big part of the problem.

Current Behavior:
1) Start Elisa
2) Browse to Music -> Albums
3) See The the 'cross' album by the artist 'Justice', with the cover for artist 'Bon Jovi' album's 'Cross'

Correct Behavior:
1) Start Elisa
2) Browse to Music -> Albums
3) See The the 'cross' album by the artist 'justice', with the cover for artist 'Justice' album's 'Cross'

Changed in elisa:
importance: Undecided → High
milestone: none → 0.5.5
assignee: nobody → osomon
Revision history for this message
Olivier Tilloy (osomon) wrote :

The faulty code is in elisa.plugins.poblesec.music_library:AlbumsViewMode : we currently don't retrieve the artist's name. There is no artist directly associated to an album, because there can be multiple artists associated to the different tracks of an album (eg on a soundtrack), but what we could do is retrieve the artist of the first track of the album and use it for the query to Amazon, that should give us much better matches already.

There is already a FIXME in the code at the place where retrieving the artist should be done.

Changed in elisa:
status: New → Confirmed
Revision history for this message
Michał Sawicz (saviq) wrote :

The Right Way(TM) here seems to be to use the 'AlbumArtist' tag, which should also be used for grouping albums inside the Library > Albums view. The AlbumArtist should then be directly associated with an album, to avoid albums like 'The Best of' being displayed as one.

If the AlbumArtist tag is empty, the TrackArtist tag (if consistent in an album) should be used.

This kind of behavior seems to be consistent among several players (i.e. iTunes, Banshee and Rhythmbox too, I think).

yyoyo (lionel.martin)
Changed in elisa:
milestone: 0.5.5 → 0.5.6
yyoyo (lionel.martin)
Changed in elisa:
assignee: osomon → lightyear
milestone: 0.5.6 → 0.5.7
yyoyo (lionel.martin)
Changed in elisa:
milestone: 0.5.7 → 0.5.8
yyoyo (lionel.martin)
Changed in elisa:
milestone: 0.5.8 → 0.5.9
yyoyo (lionel.martin)
Changed in elisa:
assignee: lightyear → philn
Philippe Normand (philn)
Changed in elisa:
status: Confirmed → In Progress
Philippe Normand (philn)
Changed in elisa:
status: In Progress → Fix Committed
Olivier Tilloy (osomon)
Changed in elisa:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.