wrong album-cover displayed
Bug #253656 reported by
Gunnar Holmberg
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Moovida |
Fix Released
|
High
|
Philippe Normand |
Bug Description
Elisa is displaying the wrong album covers for some albums. This is mainly due to the fact that the amazon is queried only with album-name - no artist-name. Just fetching the artist name from the database and query amazon with both artist-album should solve a big part of the problem.
Current Behavior:
1) Start Elisa
2) Browse to Music -> Albums
3) See The the 'cross' album by the artist 'Justice', with the cover for artist 'Bon Jovi' album's 'Cross'
Correct Behavior:
1) Start Elisa
2) Browse to Music -> Albums
3) See The the 'cross' album by the artist 'justice', with the cover for artist 'Justice' album's 'Cross'
Changed in elisa: | |
importance: | Undecided → High |
milestone: | none → 0.5.5 |
assignee: | nobody → osomon |
Changed in elisa: | |
milestone: | 0.5.5 → 0.5.6 |
Changed in elisa: | |
assignee: | osomon → lightyear |
milestone: | 0.5.6 → 0.5.7 |
Changed in elisa: | |
milestone: | 0.5.7 → 0.5.8 |
Changed in elisa: | |
milestone: | 0.5.8 → 0.5.9 |
Changed in elisa: | |
assignee: | lightyear → philn |
Changed in elisa: | |
status: | Confirmed → In Progress |
Changed in elisa: | |
status: | In Progress → Fix Committed |
Changed in elisa: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The faulty code is in elisa.plugins. poblesec. music_library: AlbumsViewMode : we currently don't retrieve the artist's name. There is no artist directly associated to an album, because there can be multiple artists associated to the different tracks of an album (eg on a soundtrack), but what we could do is retrieve the artist of the first track of the album and use it for the query to Amazon, that should give us much better matches already.
There is already a FIXME in the code at the place where retrieving the artist should be done.