[patch] AWN 0.2.6 build error on Solaris

Thanks for the patch. We'll review this patch shortly.

Out of curiosity, what's the error that occurs when the awn-effects function in question is marked as inline?

Mark, see below of the error message:

"awn-effects.c", line 178: reference to static identifier "main_effect_loop" in extern inline function
cc: acomp failed for awn-effects.c

Yeah... there's a few unecessary inlines in awn-effects.c which I've been removing as I notice them. I have no issue with that part of the patch.

I'll commit this patch to both 0.2.7 and trunk when I get the chance.

Thanks for review and upstream...

Sorry, there is a typo in the patch, I'd attach the new one. ( I forget to remove the CFLAG in configure.in. )

Someone build the AWN on Solaris and got failed, although I didn't meet this problem, after I deleted all 'inline' in libawn/awn-effects.c, then all is ok, so could it possible to remove all inline? I attached the patch, please take a check...

========error message ========
pkgbuild: Undefined first referenced
pkgbuild: symbol in file
pkgbuild: awn_effect_check_max_loops ../libawn/.libs/libawn.so
pkgbuild: awn_effect_get_priority ../libawn/.libs/libawn.so
pkgbuild: awn_effect_check_top_effect ../libawn/.libs/libawn.so
pkgbuild: apply_3d_illusion ../libawn/.libs/libawn.so
pkgbuild: lighten_component ../libawn/.libs/libawn.so
pkgbuild: ld: fatal: Symbol referencing errors. No output written to .libs/avant-window-navigator

I have no problems with the removal of the inline keyword. If anyone
does please speak up.

Assuming there is no compelling arguments to retain the inlines I say
go ahead and apply the patch. If someone else is so inclined than do
so... it may be few more days before I have a working dev system
again.

On 8/21/08, Henry <email address hidden> wrote:
> Someone build the AWN on Solaris and got failed, although I didn't meet
> this problem, after I deleted all 'inline' in libawn/awn-effects.c, then
> all is ok, so could it possible to remove all inline? I attached the
> patch, please take a check...
>
> ========error message ========
> pkgbuild: Undefined first referenced
> pkgbuild: symbol in file
> pkgbuild: awn_effect_check_max_loops ../libawn/.libs/libawn.so
> pkgbuild: awn_effect_get_priority ../libawn/.libs/libawn.so
> pkgbuild: awn_effect_check_top_effect ../libawn/.libs/libawn.so
> pkgbuild: apply_3d_illusion ../libawn/.libs/libawn.so
> pkgbuild: lighten_component ../libawn/.libs/libawn.so
> pkgbuild: ld: fatal: Symbol referencing errors. No output written to
> .libs/avant-window-navigator
>
> ** Attachment added: "avant-01-build.diff"
> http://launchpadlibrarian.net/16976325/avant-01-build.diff
>
> --
> [patch] AWN 0.2.6 build error on Solaris
> https://bugs.launchpad.net/bugs/250720
> You received this bug notification because you are a member of Awn-core,
> which is subscribed to Awn.
>

I have no problems with the removal of the inline keyword. If anyone
does please speak up.

Assuming there is no compelling arguments to retain the inlines I say
go ahead and apply the patch. If someone else is so inclined than do
so... it may be few more days before I have a working dev system
again.

Fixed in trunk in revision 473. It will be in the 0.2.7 branch shortly.