BugzillaLPPlugin.getCommentIds() and fetchComments() shouldn't expect integer comment IDs from the remote service

Bug #248662 reported by Graham Binns
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Graham Binns

Bug Description

At present, the BugzillaLPPlugin.getCommentIds() and fetchComments() methods expect the plugin API's Launchpad.comments() method to return comment IDs as integers. Unfortunately, due to the way that the data being returned from the remote server is interpreted by Python's xmlrpclib (actually the cause of the issue is in the XML-RPC spec), all Bug IDs returned by Launchpad.comments() are strings rather than integers.

fetchComments() and getCommentIds() should be updated to reflect this so as to avoid KeyErrors when looking up the comments for a particular bug.

Graham Binns (gmb)
Changed in malone:
assignee: nobody → gmb
importance: Undecided → High
milestone: none → 1.99
status: New → In Progress
Revision history for this message
Graham Binns (gmb) wrote :

Landed in r6710.

Changed in malone:
status: In Progress → Fix Committed
Graham Binns (gmb)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.