Ubuntu
linux-ubuntu-modules-2.6.24 package

Missing saa7134_alsa in proposed 2.6.24-17.24

Bug #226063 reported by Maia Everett
8
Affects Status Importance Assigned to Milestone
linux-ubuntu-modules-2.6.24 (Ubuntu)
Fix Released
Medium
Tim Gardner
Ubuntu ubuntu-8.04.1

Bug Description

The debian/changelog entry for this version says:

"Removed cx88/saa1734 media modules. Only build ALSA modules for these devices."

However, the file saa7134-alsa.ko is not actually present in the deb. The ALSA modules were removed _along_ with the main ones.

Revision history for this message
Maia Everett (linneris) wrote :

After trying to build the package from source, I found out that the media/saa7134 directory is skipped during build.

The problem seems to lie in the fact that the file media/saa7134/Makefile uses obj-$(m), while all the other directories use obj-m. Replacing obj-$(m) with obj-m causes the module to be built.

Revision history for this message
Maia Everett (linneris) wrote :

Debdiff. The change is trivial, and causes saa7134-alsa.ko to build and work correctly.

Changed in linux-ubuntu-modules-2.6.24:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
jnewton (nevion) wrote :

Lets get this committed and released! With all the trouble with saa7134-alsa the last month or two I haven't been able to use my card at all during this time. Alot of other people have these cards and the months of problems as well (201431,212271) so I think this deserves a prioritized quick fix so we are able to use them again... hopefully they won't cause oops anymore.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Matvey: are you sure the debian/changelog change in your debdiff is correct?

Revision history for this message
Daniel Holbach (dholbach) wrote :

Tim: can you please take a look at it?

Revision history for this message
Maia Everett (linneris) wrote :

I was unsure whether or not I needed to bump the version number to .25. Here's a version of the debdiff where I did.

Revision history for this message
Tim Gardner (timg-tpi) wrote :

SRU Justification:

Impact: The saa7134 and cx88 ALSA modules are not being built.

Fix Description: Correct the macro definition in the respective make files.

Patch: http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy-lum.git;a=commit;h=8213e334f2e751f4980df9937ecbafc6cf79d059

TEST CASE: The modules cx88-alsa.ko and saa7134-alsa.ko do not exist in linux-ubuntu-modules-2.6.24_2.6.24-17.24

Revision history for this message
Tim Gardner (timg-tpi) wrote :

http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy-lum.git;a=commit;h=8213e334f2e751f4980df9937ecbafc6cf79d059

Changed in linux-ubuntu-modules-2.6.24:
assignee: nobody → timg-tpi
milestone: none → ubuntu-8.04.1
status: Confirmed → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

Accepted into hardy-proposed, please test.

Revision history for this message
Maia Everett (linneris) wrote :

Yes, that fixed it. The saa7134_alsa module now present in the package works correctly.

Revision history for this message
Lubo Drobny (lubod-microstep-mis) wrote :

Also tested it's working for me OK. Thanks.

Revision history for this message
Martin Pitt (pitti) wrote :

Copied to hardy-updates.

Changed in linux-ubuntu-modules-2.6.24:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.