Pitch control inconsistencies

Bug #224326 reported by Albert Santoni
4
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Phillip Whelan

Bug Description

From the forum: http://mixxx.org/forums/viewtopic.php?f=1&t=65
====
Hi there, I've tried the mixxx 1.6beta and it's a very nice program. But there's is something not right.

When pressing the temporary tempo change (pitch bend) button while the tempo is (almost) at the max of it's range, the tempo (pitch) doesn't surpass this. Like for example the current pitch of a track is at +7.2% and you press the pitch bend which is set at -/+ 4% the pitch will be only 8% while it should be 11.2%.

Please fix this.

Another odd thing is that when selecting the technics style pitch slider direction (- up and + down) the pitch bend buttons are not in the same direction.

jan

Revision history for this message
Sean M. Pappalardo (pegasus-renegadetech) wrote :

The second issue "when selecting the technics style pitch slider direction (- up and + down) the pitch bend buttons are not in the same direction." could be quickly "fixed" by changing the up-arrow buttons (temp and perm) to plus signs and the down-arrow ones to minus signs in the skin.

Changed in mixxx:
importance: Undecided → Medium
milestone: none → 1.6.2
status: New → Confirmed
Revision history for this message
Albert Santoni (gamegod) wrote :

Unless you're going to try to fix this one Sean, I'm untargeting it from the milestone. This one is complicated to fix.

Changed in mixxx:
importance: Medium → Low
milestone: 1.6.2 → none
Revision history for this message
Sean M. Pappalardo (pegasus-renegadetech) wrote :

Yeah this is an old bug but similar stuff is happening in trunk (pre-1.8.0): Pitch bend with ramping off:

- Doesn't surpass the edge of the range (this is fine at 100% range, but not at anything lower, e.g. 90% should sill be able to bend to 94%)
- Is tied to the range. It should be fixed at 4% regardless of the range.

Changed in mixxx:
assignee: nobody → pwhelan (pwhelan)
milestone: none → 1.8.0
Revision history for this message
Sean M. Pappalardo (pegasus-renegadetech) wrote :

Ok, seems the range edge surpassing is not a problem anymore so scratch that.

On further testing it sounds like it's bending the amount of the range rather than a fixed 4%. E.g. if you've got 90% range and are at -90%, bend up sounds like 0%. If you're at 0%, bend up sounds like +90% and bend down sounds like -90%. Likewise, with 8% range, at -8% bend up goes to 0%, at 0% bend up goes to +8% and down goes to -8%.)

Revision history for this message
Sean M. Pappalardo (pegasus-renegadetech) wrote :

Tests good in trunk r2420

Changed in mixxx:
status: Confirmed → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/4952

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.