Ubuntu
firefox package

Epiphany 'Move tab to window' option doesn't work in breezy

Bug #21753 reported by Chris Lord
40
Affects Status Importance Assigned to Milestone
Mozilla Firefox
Won't Fix
High
firefox (Ubuntu)
Won't Fix
Medium
Unassigned
xulrunner-1.9 (Ubuntu)
Won't Fix
Medium
Unassigned

Bug Description

Using the 'Tabsmenu' extension in epiphany-extensions, the option to move tabs
between windows no longer works. This feature worked fine in Hoary.

https://bugzilla.mozilla.org/show_bug.cgi?id=296002: https://bugzilla.mozilla.org/show_bug.cgi?id=296002

See original description
Revision history for this message
In , c7d2f5c8667d26fffd5e7772d632c76d (c7d2f5c8667d26fffd5e7772d632c76d-deactivatedaccount) wrote :

Created attachment 184879
fix

We need to keep the mTransientParent variable updated when moving the parent
container to another toplevel.

Revision history for this message
In , c7d2f5c8667d26fffd5e7772d632c76d (c7d2f5c8667d26fffd5e7772d632c76d-deactivatedaccount) wrote :

Comment on attachment 184879
fix

This crashes when the parent container is reparented after the popup is
destroyed. New patch coming up later.

Revision history for this message
In , c7d2f5c8667d26fffd5e7772d632c76d (c7d2f5c8667d26fffd5e7772d632c76d-deactivatedaccount) wrote :

Created attachment 184942
updated patch

This patch fixes the crash, by disconnecting the signal from the parent
container when the popup is destroyed.

Revision history for this message
In , Mpgritti (mpgritti) wrote :

Comment on attachment 184942
updated patch

Some comments:

- The approach looks correct to me. The toplevel window is not specified by the
caller but nsWindow is determining it, so I think it's nsWindow job to keep it
updated. Though, I'd like someone with more knowledge of the code to take a
look.

- While we are at it I think we should fix also the dialog case. We should
probably connect the signal just after get_toplevel and have SetToplevelWindow
deal with both cases.

+ mParentContainer = parentMozContainer;

Would probably be cleaner to just store this as class member.

+ GtkWidget *toplevelCandidate = gtk_widget_get_toplevel (container);
+ GtkWidget *toplevel = GTK_WIDGET_TOPLEVEL (toplevelCandidate) ?
toplevelCandidate : nsnull;
+
+ window->SetTransientParent (GTK_WINDOW (toplevel));

Using something like if (GTK_WIDGET_TOPLEVEL (toplevel)) ... else... would be
probably more readable.

Revision history for this message
Chris Lord (cwiiis) wrote :

Using the 'Tabsmenu' extension in epiphany-extensions, the option to move tabs
between windows no longer works. This feature worked fine in Hoary.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for your bug. You can read
http://bugzilla.gnome.org/show_bug.cgi?id=303922 about that. It is this way
because of firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=296002

Revision history for this message
In , Sebastian-droege (sebastian-droege) wrote :

Any progress on this bug?

Revision history for this message
Sebastien Bacher (seb128) wrote :

*** Bug 26110 has been marked as a duplicate of this bug. ***

Revision history for this message
In , Chris-linux (chris-linux) wrote :

Again, any progress on this?

Revision history for this message
In , Sebastien Bacher (seb128) wrote :

Ubuntu bug about that: https://launchpad.net/distros/ubuntu/+source/firefox/+bug/21753

Revision history for this message
Henrik Nilsen Omma (henrik) wrote :

I can confirm that 'Tabsmenu' is broken in Epiphany 1.8.2 in breezy, but the whole extension seems to have been removed from the set in dapper. It's unlikely that we'll take further action until the extension is re-introduced by upstream, so I'm closing the bug.

Changed in firefox:
status: Unconfirmed → Rejected
Bug Watch Updater (bug-watch-updater)
Changed in firefox:
status: Unconfirmed → Confirmed
Revision history for this message
In , Mh+mozilla (mh+mozilla) wrote :

Again, any progress on this?

Revision history for this message
In , Roc-ocallahan (roc-ocallahan) wrote :

Marco minused the patch. Someone needs to submit a new patch.

Revision history for this message
Alexander Sack (asac) wrote :

upstream deals with this ... resurrect to "In Progress"

Changed in firefox:
assignee: ijackson → mozilla-bugs
status: Rejected → In Progress
Revision history for this message
In , c7d2f5c8667d26fffd5e7772d632c76d (c7d2f5c8667d26fffd5e7772d632c76d-deactivatedaccount) wrote :

Comment on attachment 184942
updated patch

This patch is also buggy; see http://bugs.debian.org/432672 (they ship this patch in their xulrunner package).

Alexander Sack (asac)
Changed in firefox:
assignee: mozilla-bugs → nobody
status: In Progress → Triaged
Changed in firefox-3.0:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Micah Gersten (micahg) wrote :

No more fixes for Firefox 2.

Changed in firefox (Ubuntu):
status: Triaged → Won't Fix
Revision history for this message
Przemek K. (azrael) wrote :

Since Epiphany now moved to Webkit from Gecko, does this bug still apply?

Revision history for this message
David Keogh (davidkeogh) wrote : Re: [Bug 21753] Re: Epiphany 'Move tab to window' option doesn't work in breezy

This bug is no longer valid. I think this feature was dropped from
Epiphany quite some time ago. It is certainly no longer there in
2.28.1 which I have on my PC.

Revision history for this message
Micah Gersten (micahg) wrote :

Xulrunner-1.9 is only receiving Security Updates and major bug fixes at this point. Epiphany Gecko is no longer developed. Therefore I am closing this bug out. Please report any other bugs you may find.

affects: firefox-3.0 (Ubuntu) → xulrunner-1.9 (Ubuntu)
Changed in xulrunner-1.9 (Ubuntu):
status: Triaged → Won't Fix
Bug Watch Updater (bug-watch-updater)
Changed in firefox:
importance: Unknown → High
Bug Watch Updater (bug-watch-updater)
Changed in firefox:
status: Confirmed → Unknown
Bug Watch Updater (bug-watch-updater)
Changed in firefox:
status: Unknown → Confirmed
Revision history for this message
In , Stransky (stransky) wrote :

We're not going to fix that.

Bug Watch Updater (bug-watch-updater)
Changed in firefox:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.