machine_comment not accessible from templates

Bug #214202 reported by Aaron Swartz
2
Affects Status Importance Assigned to Milestone
Open Library
Fix Released
Medium
Anand Chitipothu

Bug Description

We need to start displaying machine_comment on the edition/view.tmpl page.

Aaron Swartz (aaronsw)
Changed in openlibrary:
assignee: nobody → anandology
importance: Undecided → Medium
milestone: none → 1.0
status: New → Confirmed
Revision history for this message
Anand Chitipothu (anandology) wrote : Re: [Bug 214202] [NEW] machine_comment not accessible from templates

> We need to start displaying machine_comment on the edition/view.tmpl
> page.

The machine_comment is not available in "thing" object. It is only
available in the first "version" object.

If you want I can display it in the history along with comment.

Revision history for this message
Aaron Swartz (aaronsw) wrote :

1. Please add it to the history.
2. Please make the history accessible from the thing so that we can
display it on the edition page as well.

Revision history for this message
Anand Chitipothu (anandology) wrote :

On Wed, Apr 9, 2008 at 7:24 AM, Aaron Swartz <email address hidden> wrote:
> 1. Please add it to the history.

Fine.

> 2. Please make the history accessible from the thing so that we can
> display it on the edition page as well.

I have performance issues with this.
If you want to display in the view, then why not add as a property to
the object?

Revision history for this message
Aaron Swartz (aaronsw) wrote :

> > 2. Please make the history accessible from the thing so that we can
> > display it on the edition page as well.
>
> I have performance issues with this.
> If you want to display in the view, then why not add as a property to
> the object?

Can't it be cached? The idea is to display the history of the page --
where the data came from -- on the page.

Revision history for this message
Anand Chitipothu (anandology) wrote :

> Can't it be cached? The idea is to display the history of the page --
> where the data came from -- on the page.

What is the problem with adding it as a property?
History has only the latest 20 versions, when there are more versions
for a page, then we can't get the machine_comment.

Revision history for this message
Anand Chitipothu (anandology) wrote :

it is added to the history.

Changed in openlibrary:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.