Autogenerated forms do not have correct tab order

Does this still occur?

A quick inspection showed a few forms (on launchpad.net) where that still occurs:

The product edit page:
 https://launchpad.net/products/automake/+edit

The product admin page:
https://launchpad.net/products/automake/+review

The series admin page:
https://launchpad.net/products/automake/+series/main/+review

The milestone creation page:
https://launchpad.net/products/automake/+addmilestone

The series package linkage page:
https://launchpad.net/products/automake/+series/main/+addpackage

The release creation page:
https://launchpad.net/products/automake/+series/main/+addrelease

Some more aggressively broken ones:

The product creation page:
https://launchpad.net/products/+new

The product creation page:
https://launchpad.net/products/+new

Here, starting on the first form input, pressing tab once sends the focus to the submit button, pressing tab again sends focus somewhere in the landscape, and many more tabs are required to reach the second form input.

Just from a cursory look on the forms I'm familiar with, this is by no mean exhaustive.

The account activation page (where you fill in your details after getting a token) also does this, and managed to completely throw me off for five minutes or so.

It also happens when editing bug details (e.g. changing description). I would heartily like this fixed.

Also happens when adding a bug attachment:

 https://launchpad.net/products/launchpad/+bug/34880/+addattachment

Also happens here:

  https://launchpad.net/products/bzr/+spec/bzrarchives/+status

kiko, any chance of prioritizing this?

I've got some fixes in my formlib branch to allow us to set focus on the initial form widget without the tabindex problems.

So this bug should gradually go away as we switch to the new form view classes.

Any update on this? The bug still persists in the new products page.

Burhan: our new form infrastructure allows us to set the form focus without screwing up the tabbing order. However, this only affects forms using the new infrastructure. We'll be moving all the forms over eventually, but for now the majority of the forms are still on the old infrastructure.

Perhaps we should make it a priority to migrate all the forms that are explicitly setting tabindex. That'd fix most of the user visible problems.

I've merged a branch that gets rid of the tabindex usage outside of the Rosetta forms (where they seem to have taken care to assign tabindex to all the items that should be in the primary focus chain).

Together with the fixes for LaunchpadFormView, I think we can consider this bug fixed.

fix included in today's rollout

On 22/11/2006, at 10:38 PM, James Henstridge wrote:

> fix included in today's rollout

you rock!

--
Martin