Brightness control no longer works under Hardy

Bug #207183 reported by Michael Frey
10
Affects Status Importance Assigned to Milestone
Moblin Applets
Fix Released
Critical
ToddBrandt
Ubuntu Mobile Edition
Fix Released
Critical
Unassigned

Bug Description

Using the latest moblin-applets under the UME hardy build, screen brightness control no longer works.

The error is .xsession-errors is:

SetBrightness failed: brightness has to be between 0 and 7

I think the new version of HAL is expecting something different than the version in Gutsy.

This is another reason to re-sync moblin-applets with gnome-power-manager.

Tags: intel
Michael Frey (mfrey)
Changed in moblin-applets:
assignee: nobody → todd-e-brandt
Revision history for this message
Axel Lin (axel-lin) wrote :

I also found it doesnot work in Gutsy neither.
Test on Moblin-applets v0.50.1

Revision history for this message
cathyli (cathy-li) wrote :

Do you try on Q1, CB, or Xehpyr? I tried it in applets 0.50.1 under Hardy in my Q1 ultra, brightness works well.
Could you have a try on Q1 ultra?

Revision history for this message
cathyli (cathy-li) wrote :

Mark it as "Incomplete" temporarily due need more info.

Changed in moblin-applets:
status: New → Incomplete
Revision history for this message
Michael Frey (mfrey) wrote :

This problem started to happen when HAL was upgraded in Hardy to version
0.5.11~rc2-1ubuntu3

Please check the version of HAL you are testing against.

Changed in acton:
assignee: nobody → mfrey
importance: Undecided → High
milestone: none → beta1
status: New → Triaged
Chris Gregan (cgregan)
Changed in moblin-applets:
status: Incomplete → Confirmed
Revision history for this message
Michael Frey (mfrey) wrote :

Attached is patch that fixes the problem.

Revision history for this message
Luke (luke-yang) wrote :

I have downloaded the latest moblin-applets package (moblin-applets-0.50.1jax3) this morning.
It already included modified code as your mention.
However, it still can't work. could you please confirm it again?

test environment:
image : Compal 0320 image (base on 0313 Canoncial formal released)
unit1: pre-DVT2 / 029A
unit2: DVT / 030T05
these two units have the same failure symptom.

test procedure.
1. Test the brightness function of Marquee with 0320 image. it can work but has some problems as below.
  (1) The level 2 of brightness controll is wrong.
  (2) The level value of scroll bar is dis-match. ( adjust brightness to level 0 and close it. it may locate at level 7 when re-open the scroll bar)
2. Install the latest moblin-applets (moblin-applets-0.50.1jax3) and reboot.
3. The brightness control of Marquee is no funtion

thanks a lot
Luke

Revision history for this message
Michael Frey (mfrey) wrote :

Luke,

This will not work until the beta image. The brightness fix requires more packages than just moblin-applets.

Michael

Chris Gregan (cgregan)
Changed in ubuntu-mobile:
status: New → Confirmed
Revision history for this message
ToddBrandt (todd-e-brandt) wrote :

This is functional with moblin-applets 0.54

Changed in moblin-applets:
status: Confirmed → Fix Committed
Revision history for this message
ToddBrandt (todd-e-brandt) wrote :

One note is that I should upgrade the brightness applet to first read in what the discrete brightness levels are dynamically instead of hard coding them.

Revision history for this message
Chris Gregan (cgregan) wrote :

This fix fails in UME Daily 20081404 which is running moblin-apps v.54. Please confirm this defect is infact fixed.

Changed in moblin-applets:
status: Fix Committed → Incomplete
Revision history for this message
Mauri Whalen (mauri-whalen) wrote :

Todd needs to verify on a Crown Beach.
Canonical to verify on Jax10.

Changed in moblin-applets:
importance: Undecided → High
milestone: none → m11
Revision history for this message
Tony Espy (awe) wrote :

Verified on jax10 per yesterday's triage meeting.

Changed in acton:
status: Triaged → Fix Committed
Revision history for this message
ToddBrandt (todd-e-brandt) wrote :

ok, I just verified the bug. The output I get is this:

** (gecko:5102): WARNING **: SetBrighness Failed: Brightness has to be between 0 and 7

The problem is that the new hald changes in hardy have a different set of discrete values for the brightness than they did before. Previously the values were between 0 and 100, specifically: 0, 10, 30, 40, 50, 60, 70, 80, 100. With the latest hald the values are between 0 and 7. I need to add logic which detects the brightness range and values instead of hardcoding them. I've changed the bug to critical as this is pretty serious.

Changed in moblin-applets:
importance: High → Critical
status: Incomplete → Confirmed
Revision history for this message
ToddBrandt (todd-e-brandt) wrote :

incidentally, gnome-power-manager in gutsy also hardcoded the values as I took the code straight from it.

Revision history for this message
ToddBrandt (todd-e-brandt) wrote :

Fix committed in 0.57 moblin-applets. I changed the libbrightnesscontrol code to read the value of the laptop_panel.num_levels value in the HAL laptop_panel namespace. This value is the number of discrete brightness levels, and the new behavior seems to be that the actual levels are 0-num_levels-1. I updated the libbrightnessconrol library and the brightness applet and moblin-settings-daemon (which sets the brightness for shortcut keys). It appears to work well now.

Changed in moblin-applets:
status: Confirmed → Fix Committed
Chris Gregan (cgregan)
Changed in ubuntu-mobile:
importance: Undecided → Critical
status: Confirmed → Fix Committed
Revision history for this message
Steve Kowalik (stevenk) wrote :

This looks fixed for me with the 20080506 daily on a Q1. Can anyone else confirm that it's fixed, and I'll close the bug for UME.

Todd, I think you're okay to set the Moblin Applets task to Fix Released.

Revision history for this message
Chris Gregan (cgregan) wrote :

Confirmed fixed in Mccaslin 20080506 and UME Beta 4

Steve Kowalik (stevenk)
Changed in ubuntu-mobile:
status: Fix Committed → Fix Released
Changed in moblin-applets:
status: Fix Committed → Fix Released
Steve Magoun (smagoun)
Changed in acton:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.