Evergreen

Staff catalog does not display record summary for bibs with no metarecord source map

Bug #2039229 reported by Jeff Davis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
New
Undecided
Unassigned
Evergreen 3.11.2

Bug Description

EG 3.11+

In the staff catalog, if you retrieve a bib record has no entry in metabib.metarecord_source_map, the record summary is not displayed. Specifically, the entire record summary table is missing from the page, and the browser console shows a message like this:

open-ils.search.biblio.record.catalog_summary.staff failed! stat=500 msg= *** Call to [open-ils.search.biblio.record.catalog_summary.staff] failed for session [...], thread trace [0]:
Can't call method "metarecord" on an undefined value at /usr/local/share/perl/5.30.0/OpenILS/Application/Search/Biblio.pm line 3174.

Here's one possible way to reproduce the issue:

1. Ensure the ingest.metarecord_mapping.preserve_on_delete internal flag is set to false.
2. Delete a record. This will remove metarecord mappings for the record from metabib.metarecord_source_map.
3. Reload the record by refreshing the page or retrieving the record in a new tab.

Jeff Davis (jdavis-sitka)
Changed in evergreen:
assignee: nobody → Jeff Davis (jdavis-sitka)
tags: added: staffcatalog
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Working branch user/jeffdavis/lp2039229-record-summary-without-metarecord-mapping has a potential fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp2039229-record-summary-without-metarecord-mapping

Test plan:

1. Ensure the ingest.metarecord_mapping.preserve_on_delete internal flag is set to false.
2. Delete a record. This will remove metarecord mappings for the record from metabib.metarecord_source_map.
3. In the staff catalog, reload the record by refreshing the page or retrieving the record in a new tab. The record summary table does not display.
4. Apply the fix and restart EG.
5. Repeat step 3. The record summary should now appear correctly.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.11.2
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

This fix will make the record summary table show up, but the Staff View tab still won't work unless there is a metarecord mapping, which is incompatible with setting the ingest.metarecord_mapping.preserve_on_delete flag to false.

Changed in evergreen:
assignee: Jeff Davis (jdavis-sitka) → nobody
tags: removed: pullrequest
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Okay, here's a branch that makes Staff View work with bibs that don't have metarecord mappings:

working/user/jeffdavis/lp2039229-staff-view-without-metarecord / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp2039229-staff-view-without-metarecord

tags: added: pullrequest
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.