command openstack overcloud network extract failed when network isolation isn't used

A little bit more of debugging

(undercloud) [stack@director ~]$ openstack overcloud network extract --stack overcloud \
--output /home/stack/overcloud-deploy/overcloud/tripleo-overcloud-network-data.yaml --yes --debug

2023-07-12 07:37:44.089820 | 2cc26024-0e20-6fcc-40ed-00000000000a | TIMING | Check if output file exists | localhost | 0:00:00.329257 | 0.24s
2023-07-12 07:37:44.114544 | 2cc26024-0e20-6fcc-40ed-00000000000b | SKIPPED | fail | localhost
2023-07-12 07:37:44.115278 | 2cc26024-0e20-6fcc-40ed-00000000000b | TIMING | fail | localhost | 0:00:00.354717 | 0.02s
META: ran handlers
2023-07-12 07:37:44.117780 | 2cc26024-0e20-6fcc-40ed-00000000000d | TASK | Get network data from overcloud stack
Using module file /usr/share/ansible/plugins/modules/tripleo_overcloud_network_extract.py
Pipelining is enabled.
<127.0.0.1> ESTABLISH LOCAL CONNECTION FOR USER: stack
<127.0.0.1> EXEC /bin/sh -c '/usr/libexec/platform-python && sleep 0'
The full traceback is:
  File "/tmp/ansible_tripleo_overcloud_network_extract_payload_vz72cwgo/ansible_tripleo_overcloud_network_extract_payload.zip/
 ansible/modules/tripleo_overcloud_network_extract.py", line 288, in run_module
  File "/tmp/ansible_tripleo_overcloud_network_extract_payload_vz72cwgo/ansible_tripleo_overcloud_network_extract_payload.zip/
 ansible/module_utils/network_data_v2.py", line 463, in get_overcloud_network_resources
    for res in conn.orchestration.resources(net.physical_resource_id):
  File "/usr/lib/python3.6/site-packages/openstack/orchestration/v1/_proxy.py", line 276, in resources
    obj = self._find(_stack.Stack, stack, ignore_missing=False)
  File "/usr/lib/python3.6/site-packages/openstack/proxy.py", line 371, in _find
    **attrs)
  File "/usr/lib/python3.6/site-packages/openstack/orchestration/v1/stack.py", line 241, in find
    "No %s found for %s" % (cls.__name__, name_or_id))
2023-07-12 07:37:46.977123 | 2cc26024-0e20-6fcc-40ed-00000000000d | FATAL | Get network data from overcloud stack | localhost | error={
    "changed": false,
    "error": "No Stack found for e1e57091-0283-4c1e-a04a-450b1a3cbc0b",
    "invocation": {
        "module_args": {
            "api_timeout": null,
            "auth": null,
            "auth_type": null,
            "availability_zone": null,
            "ca_cert": null,
            "client_cert": null,
            "client_key": null,
            "interface": "public",
            "region_name": null,
            "stack_name": "overcloud",
            "timeout": 180,
            "validate_certs": null,
            "wait": true
        }
    },
    "msg": "Error getting network data from overcloud stack overcloud: %No Stack found for e1e57091-0283-4c1e-a04a-450b1a3cbc0b",
    "network_data": [],
    "success": false
}

https://review.opendev.org/c/openstack/tripleo-ansible/+/888236 was merged

Reopening - new issue - https://bugzilla.redhat.com/show_bug.cgi?id=2237255

    "stderr": "INFO:undercloud:Exporting network from stack overcloud to /home/stack/overcloud-deploy/overcloud/tripleo-overcloud-network-data.yaml\nINFO:undercloud:Exporting network virtual IPs from stack overclou
d to /home/stack/overcloud-deploy/overcloud/tripleo-overcloud-virtual-ips.yaml\nINFO:undercloud:Exporting provisioned nodes from stack overcloud to /home/stack/overcloud-deploy/overcloud/tripleo-overcloud-baremetal
-deployment.yaml\nUnable to extract role networks. Network storage not found.\nTraceback (most recent call last):\n File \"/var/lib/tripleo-config/scripts/undercloud-upgrade-ephemeral-heat.py\", line 443, in <modu
le>\n main()\n File \"/var/lib/tripleo-config/scripts/undercloud-upgrade-ephemeral-heat.py\", line 383, in main\n export_provisioned_nodes(heat, stack, stack_dir, args.cloud)\n File \"/var/lib/tripleo-confi
g/scripts/undercloud-upgrade-ephemeral-heat.py\", line 332, in export_provisioned_nodes\n '--working-dir', stack_dir, '--yes'], env={'OS_CLOUD': cloud})\n File \"/usr/lib64/python3.6/subprocess.py\", line 311,
in check_call\n raise CalledProcessError(retcode, cmd)\nsubprocess.CalledProcessError: Command '['openstack', 'overcloud', 'node', 'extract', 'provisioned', '--stack', 'overcloud', '--roles-file', '/tmp/tmpctxjq
epx', '--output', '/home/stack/overcloud-deploy/overcloud/tripleo-overcloud-baremetal-deployment.yaml', '--working-dir', '/home/stack/overcloud-deploy/overcloud', '--yes']' returned non-zero exit status 1.",
    "stderr_lines": [
        "INFO:undercloud:Exporting network from stack overcloud to /home/stack/overcloud-deploy/overcloud/tripleo-overcloud-network-data.yaml",
        "INFO:undercloud:Exporting network virtual IPs from stack overcloud to /home/stack/overcloud-deploy/overcloud/tripleo-overcloud-virtual-ips.yaml",
        "INFO:undercloud:Exporting provisioned nodes from stack overcloud to /home/stack/overcloud-deploy/overcloud/tripleo-overcloud-baremetal-deployment.yaml",
        "Unable to extract role networks. Network storage not found.",
        "Traceback (most recent call last):",
        " File \"/var/lib/tripleo-config/scripts/undercloud-upgrade-ephemeral-heat.py\", line 443, in <module>",
        " main()",
        " File \"/var/lib/tripleo-config/scripts/undercloud-upgrade-ephemeral-heat.py\", line 383, in main",
        " export_provisioned_nodes(heat, stack, stack_dir, args.cloud)",
        " File \"/var/lib/tripleo-config/scripts/undercloud-upgrade-ephemeral-heat.py\", line 332, in export_provisioned_nodes",
        " '--working-dir', stack_dir, '--yes'], env={'OS_CLOUD': cloud})",
        " File \"/usr/lib64/python3.6/subprocess.py\", line 311, in check_call",
        " raise CalledProcessError(retcode, cmd)",
        "subprocess.CalledProcessError: Command '['openstack', 'overcloud', 'node', 'extract', 'provisioned', '--stack', 'overcloud', '--roles-file', '/tmp/tmpctxjqepx', '--output', '/home/stack/overcloud-deploy/ov
ercloud/tripleo-overcloud-baremetal-deployment.yaml', '--working-dir', '/home/stack/overcloud-deploy/overcloud', '--yes']' returned non-zero exit...

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/893684

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/893684
Committed: https://opendev.org/openstack/python-tripleoclient/commit/b6fb1e58b1930484a850b20e75b508b106dab429
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit b6fb1e58b1930484a850b20e75b508b106dab429
Author: Harald Jensås <email address hidden>
Date: Mon Sep 4 19:57:09 2023 +0200

    Fix node extract when no network-isolation

    When network isolation is not enabled by
    environments/network-isolation.yaml the networks in the default
    networks file is not created. But the RoleNetIpMap still have
    entries for each network all with the ctlplane IP address.

    This change re-factors the code to ignore RoleNetIpMap entries
    when the network is not found/does not exist.

    Change-Id: If35ff8a1b3d9b4e93e6151c9c28d8e9c707bc64a
    Closes-Bug: #2027580