periodic-tripleo-ci-centos-8-scenario001-standalone-train failed on image uploader

From what I could see, it is related to this patch

https://github.com/openstack/tripleo-common/commit/464aad0ab84ef8f795905d7a10349593931703ed

As you can see in the logs:

https://logserver.rdoproject.org/openstack-periodic-integration-stable4/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-8-scenario001-standalone-train/021d139/logs/undercloud/home/zuul/standalone_deploy.log.txt.gz

20230708100703] Finished copying", "INFO:tripleo_common.image.image_uploader:[quay.rdoproject.org/tripleotraincentos8/centos-binary-ovn-sb-db-server:aeb34aa361d38fe918a8f9c7ce25d082] Completed modify and upload for image", "ERROR:root:Image prepare failed: local variable 'new_manifest_type' referenced before assignment", "concurrent.futures.process._RemoteTraceback: ", "\"\"\"", "Traceback (most recent call last):", " File \"/usr/lib64/python3.6/concurrent/futures/process.py\", line 175, in _process_worker", " r = call_item.fn(*call_item.args, **call_item.kwargs)", " File \"/usr/lib64/python3.6/concurrent/futures/process.py\", line 153, in _process_chunk", " return [fn(*args) for args in chunk]", " File \"/usr/lib64/python3.6/concurrent/futures/process.py\", line 153, in <listcomp>", " return [fn(*args) for args in chunk]", " File \"/usr/lib/python3.6/site-packages/tripleo_common/image/image_uploader.py\", line 2759, in upload_task", " return uploader.upload_image(task)", " File \"/usr/lib/python3.6/site-packages/tripleo_common/image/image_uploader.py\", line 1700, in upload_image", " multi_arch=t.multi_arch", " File \"/usr/lib/python3.6/site-packages/tenacity/__init__.py\", line 292, in wrapped_f", " return self.call(f, *args, **kw)", " File \"/usr/lib/python3.6/site-packages/tenacity/__init__.py\", line 358, in call", " do = self.iter(retry_state=retry_state)", " File \"/usr/lib/python3.6/site-packages/tenacity/__init__.py\", line 319, in iter", " return fut.result()", " File \"/usr/lib64/python3.6/concurrent/futures/_base.py\", line 425, in result", " return self.__get_result()", " File \"/usr/lib64/python3.6/concurrent/futures/_base.py\", line 384, in __get_result", " raise self._exception", " File \"/usr/lib/python3.6/site-packages/tenacity/__init__.py\", line 361, in call", " result = fn(*args, **kwargs)", " File \"/usr/lib/python3.6/site-packages/tripleo_common/image/image_uploader.py\", line 2104, in _copy_registry_to_registry", " multi_arch=multi_arch", " File \"/usr/lib/python3.6/site-packages/tripleo_common/image/image_uploader.py\", line 2171, in _copy_manifest_config_to_registry", " new_manifest_type,", "UnboundLocalError: local variable 'new_manifest_type' referenced before assignment", "\"\"\"", "", "The above exception was the direct cause of the following exception:", "", "Traceback (most recent call last):", " File \"/usr/bin/tripleo-container-image-prepare\", line 138, in <module>", " lock=lock)", " File \"/usr/lib/python3.6/site-packages/tripleo_common/image/kolla_builder.py\", line 245, in container_images_prepare_multi", " uploader.upload()", " File \"/usr/lib/python3.6/site-packages/tripleo_common/image/image_uploader.py\", line 604, in upload", " uploader.run_tasks()", " File \"/usr/lib/python3.6/site-packages/tripleo_common/image/image_uploader.py\", line 2701, in run_tasks", " for result in p.map(upload_task, self.upload_tasks):", " File \"/usr/lib64/python3.6/concurrent/futures/process.py\", line 366, in _chain_from_iterable_of_lists", " for element in iterable:", " File \"/usr/lib64/python3.6/concurrent/futures/_base.py\", line 586, in result_iterator", " yield fs.pop().result()", " File \"/usr/lib64/python3.6/concurrent/futures/_base.py\", line 425, in result", " return self.__get_result()", " File \"/usr/lib64/python3.6/concurrent/futures/_base.py\", line 384, in __get_result", " raise self._exception", "UnboundLocalError: local variable 'new_manifest_type' referenced before assignment"], "stdout": "", "stdout_lines": []}

We only see this now because we were having issues with ibmcloud, now that we move train to vexxhost, we are seeing it.