rules-repo config description incorrect
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Prometheus2 charm |
Fix Released
|
Undecided
|
Chris Johnston |
Bug Description
rules-repo:
type: string
description: |
Git repository with custom rules. Rules have to be in *.rules files
This would indicate that any file that doesn't end in .rules would be ignored. In reality, it appears that .rules, .yaml, and .yml files are all considered valid:
for root, dirs, filenames in os.walk(
for filename in filenames:
# Ignore files such as .launchpad.yaml and .yamllint.yaml
if filename.
match = re.match(
if match:
# Wildcard filename part to allow rule files to disappear
return sorted(
Related branches
- Eric Chen: Approve
- 🤖 prod-jenkaas-bootstack: Approve (continuous-integration)
- BootStack Reviewers: Pending requested
-
Diff: 21 lines (+2/-1)1 file modifiedsrc/config.yaml (+2/-1)
Changed in charm-prometheus2: | |
assignee: | nobody → Chris Johnston (cjohnston) |
status: | New → Fix Committed |
Changed in charm-prometheus2: | |
milestone: | none → 23.07 |
Changed in charm-prometheus2: | |
status: | Fix Committed → Fix Released |