[snap] Cannot open containing folder from a downloaded item if the default path is changed

Created attachment 9203705
download

*Affected versions*
* 86.0 (20210215141125)
* 85.0.2 (20210216094005)
* 78.8.0esr (20210217034806)

*Preconditions*
* Download the build from the archive and run `snap install --dangerous target.snap`

*Affected platforms*
* Ubuntu 18.04

*Steps to reproduce*
1. Open Firefox and change the default download folder from about:preferences.
2. Download a random file [e.g](https://www.thinkbroadband.com/download).
3. Click on Open containing folder from downloads pane.

*Expected result*
* Folder is opened as expected.

*Actual result*
* The folder is not opened.

*Regression range*
* I will search for one ASAP.

*Notes*
* Attached a screen recording.
* I tried on another ubuntu 18.04 machine and the issue is not reproducing. Maybe is something related to my station.

Hello! I tried searching for a regression range on my Ubuntu machine and these are the results:
- latest good build is Firefox snap 75.0b11 -> This build opens the folder with the downloaded file as expected
- first bad build is Firefox snap 76.0b1 -> This build opens a Launch Application window instead of the folder containing the downloaded file even when the default download folder is kept.
I made a [pushlog](https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=c8d69165e663b8c6e8074ac01151ab4d9c3a5fd2&tochange=b4ef8571957b03316302e9dd21979a0d2612f648) between these two...

This are the results between the bad build wich is opening Launch Application window and the build that is not opening anything when another download folder is set:
- 77.0b4 snap build -> opens a Launch Application window as well even when is default downloads folder kept
- 77.0b5 snap build -> opens the default download folder as expected but does not open anything when the default download folder is changed as described in comment 0.
Pushlog: [link](https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=f2f4bb3f05ec9b0eb185d5825b46874c8730f6b4&tochange=0561052e38b299b6d7b18141d65ed6a32f152a8d)

Can we detect that attempting to reveal an `nsIFile` will be blocked by flatpak/snap? Is there some way to convince it to allow this to happen?

*** Bug 1756817 has been marked as a duplicate of this bug. ***

There was another bug about not being able to use `Open file in folder` and it was just missing feature under snap. Can you verify https://bugzilla.mozilla.org/show_bug.cgi?id=1772063 ? It's likely a dupe.

Created attachment 9303268
vokoscreen-2022-11-14_10-10-48.gif

(In reply to Alexandre LISSY :gerard-majax from comment #4)
> There was another bug about not being able to use `Open file in folder` and it was just missing feature under snap. Can you verify https://bugzilla.mozilla.org/show_bug.cgi?id=1772063 ? It's likely a dupe.

We tried these steps again on two Ubuntu 18.04 machines and we can still reproduce this issue with Firefox 107.0RC2. Attaching a screen recording as well.

(In reply to Alexandru Trif, QA [:atrif] from comment #5)
> Created attachment 9303268
> vokoscreen-2022-11-14_10-10-48.gif
>
> (In reply to Alexandre LISSY :gerard-majax from comment #4)
> > There was another bug about not being able to use `Open file in folder` and it was just missing feature under snap. Can you verify https://bugzilla.mozilla.org/show_bug.cgi?id=1772063 ? It's likely a dupe.
>
> We tried these steps again on two Ubuntu 18.04 machines and we can still reproduce this issue with Firefox 107.0RC2. Attaching a screen recording as well.

Can you try on 22.04 pleaase ?

Created attachment 9303285
image.png

(In reply to Alexandre LISSY :gerard-majax from comment #6)
> (In reply to Alexandru Trif, QA [:atrif] from comment #5)
> > Created attachment 9303268
> > vokoscreen-2022-11-14_10-10-48.gif
> >
> > (In reply to Alexandre LISSY :gerard-majax from comment #4)
> > > There was another bug about not being able to use `Open file in folder` and it was just missing feature under snap. Can you verify https://bugzilla.mozilla.org/show_bug.cgi?id=1772063 ? It's likely a dupe.
> >
> > We tried these steps again on two Ubuntu 18.04 machines and we can still reproduce this issue with Firefox 107.0RC2. Attaching a screen recording as well.
>
> Can you try on 22.04 pleaase ?

Sure. I cannot reproduce the issue on Ubuntu 22.04. One thing worth mentioning is that on Ubuntu 22.04 the downloads folder path is correctly displayed. On ubuntu 18 there is some strange download path displayed. Please see the attached screenshot.

(In reply to Alexandru Trif, QA [:atrif] from comment #5)
> Created attachment 9303268
> vokoscreen-2022-11-14_10-10-48.gif
>
> (In reply to Alexandre LISSY :gerard-majax from comment #4)
> > There was another bug about not being able to use `Open file in folder` and it was just missing feature under snap. Can you verify https://bugzilla.mozilla.org/show_bug.cgi?id=1772063 ? It's likely a dupe.
>
> We tried these steps again on two Ubuntu 18.04 machines and we can still reproduce this issue with Firefox 107.0RC2. Attaching a screen recording as well.

Can you share an actual video? It's going way too fast and there's no way to pause ... Please do the recording on a 22.04, and please verify on a brand new setup as well.

Created attachment 9305795
vokoscreen-2022-11-29_15-53-00.mkv

(In reply to Alexandre LISSY :gerard-majax from comment #8)
> Can you share an actual video? It's going way too fast and there's no way to pause ... Please do the recording on a 22.04, and please verify on a brand new setup as well.

Hello! I cannot reproduce the issue on Ubuntu 22.04. I have made a new screen recording on my Ubuntu 18.04 station starting with a new profile and then changing the download folder. Hope it helps. If more information is needed please let me know. Thank you!

(In reply to Alexandru Trif, QA [:atrif] from comment #9)
> Created attachment 9305795
> vokoscreen-2022-11-29_15-53-00.mkv
>
> (In reply to Alexandre LISSY :gerard-majax from comment #8)
> > Can you share an actual video? It's going way too fast and there's no way to pause ... Please do the recording on a 22.04, and please verify on a brand new setup as well.
>
> Hello! I cannot reproduce the issue on Ubuntu 22.04. I have made a new screen recording on my Ubuntu 18.04 station starting with a new profile and then changing the download folder. Hope it helps. If more information is needed please let me know. Thank you!

I'm a bit worried you are not able to reproduce anymore, this would suggest it was indeed fixed on 22.04. Can you confirm that ?

FTR Opening in folder was fixed in bug 1772063

I've been told the situation should have been fixed on 18.04 as well: https://bugs.launchpad.net/ubuntu/+source/xdg-desktop-portal/+bug/1978295

Can you verify if everything is correctly uptodate? And if it's the case, then I guess we should file a bug upstream and link it from there to backport what is missing.

(In reply to Alexandre LISSY :gerard-majax from comment #12)
> I've been told the situation should have been fixed on 18.04 as well: https://bugs.launchpad.net/ubuntu/+source/xdg-desktop-portal/+bug/1978295
>
> Can you verify if everything is correctly uptodate? And if it's the case, then I guess we should file a bug upstream and link it from there to backport what is missing.

I updated Ubuntu and tried again with 108.0b9 snap on my main Ubuntu profile and the issue still occurs.
I created a new Ubuntu profile and tried with 108.0b9 snap and I cannot reproduce the issue there. The folder is correctly opened from Firefox after the download directory is changed. Also, the correct path is displayed inside about:preferences > Downloads > Save files to section.
Maybe it's something with my main Ubuntu profile, but unfortunately, I don't know what.

(In reply to Alexandru Trif, QA [:atrif] from comment #13)
> (In reply to Alexandre LISSY :gerard-majax from comment #12)
> > I've been told the situation should have been fixed on 18.04 as well: https://bugs.launchpad.net/ubuntu/+source/xdg-desktop-portal/+bug/1978295
> >
> > Can you verify if everything is correctly uptodate? And if it's the case, then I guess we should file a bug upstream and link it from there to backport what is missing.
>
> I updated Ubuntu and tried again with 108.0b9 snap on my main Ubuntu profile and the issue still occurs.
> I created a new Ubuntu profile and tried with 108.0b9 snap and I cannot reproduce the issue there. The folder is correctly opened from Firefox after the download directory is changed. Also, the correct path is displayed inside about:preferences > Downloads > Save files to section.
> Maybe it's something with my main Ubuntu profile, but unfortunately, I don't know what.

`about:support` on both profile, we should be able to diff ?

(In reply to Alexandre LISSY :gerard-majax from comment #14)
> (In reply to Alexandru Trif, QA [:atrif] from comment #13)
> > (In reply to Alexandre LISSY :gerard-majax from comment #12)
> > > I've been told the situation should have been fixed on 18.04 as well: https://bugs.launchpad.net/ubuntu/+source/xdg-desktop-portal/+bug/1978295
> > >
> > > Can you verify if everything is correctly uptodate? And if it's the case, then I guess we should file a bug upstream and link it from there to backport what is missing.
> >
> > I updated Ubuntu and tried again with 108.0b9 snap on my main Ubuntu profile and the issue still occurs.
> > I created a new Ubuntu profile and tried with 108.0b9 snap and I cannot reproduce the issue there. The folder is correctly opened from Firefox after the download directory is changed. Also, the correct path is displayed inside about:preferences > Downloads > Save files to section.
> > Maybe it's something with my main Ubuntu profile, but unfortunately, I don't know what.
>
> `about:support` on both profile, we should be able to diff ?

Oh... sorry... I mistakenly opened Firefox 108.0b9 which came installed default with Ubuntu 18... and with that version, it seems that the issue is not reproducible... Sorry for the confusion here.

I can still reproduce the issue with Firefox 108.0b9 Snap installed with `sudo snap install firefox --channel=beta` command on the newly created Ubuntu profile as well. If more information is needed please let me know. Thank you!

Sorry but this is just adding confusion. You confirmed the issue does not reproduce without snap, and it still reproduces with snap on ubuntu 18.04. So according to my comment 12, you should file an upstream issue so the missing bits are backported (I dont know which ones).

Have you filed an upstream issue ?

(In reply to Alexandre LISSY :gerard-majax from comment #17)
> Have you filed an upstream issue ?

Unfortunately no, I can still reproduce the issue on Ubuntu 18.04 with Firefox 112.0b2 snap, but unfortunately, I still don't know how to file the issue. If you could provide me with some guidance on how to do this it would be great. Thank you!

(In reply to Alexandru Trif, QA [:atrif] from comment #18)
> (In reply to Alexandre LISSY :gerard-majax from comment #17)
> > Have you filed an upstream issue ?
>
> Unfortunately no, I can still reproduce the issue on Ubuntu 18.04 with Firefox 112.0b2 snap, but unfortunately, I still don't know how to file the issue. If you could provide me with some guidance on how to do this it would be great. Thank you!

Bouncing needinfo back to Alexandre. :-)

(In reply to Alexandru Trif, QA [:atrif] from comment #18)
> (In reply to Alexandre LISSY :gerard-majax from comment #17)
> > Have you filed an upstream issue ?
>
> Unfortunately no, I can still reproduce the issue on Ubuntu 18.04 with Firefox 112.0b2 snap, but unfortunately, I still don't know how to file the issue. If you could provide me with some guidance on how to do this it would be great. Thank you!

You need to file an issue on Launchpad https://launchpad.net/ against the Firefox package.

(In reply to Alexandre LISSY :gerard-majax from comment #20)
> (In reply to Alexandru Trif, QA [:atrif] from comment #18)
> > (In reply to Alexandre LISSY :gerard-majax from comment #17)
> > > Have you filed an upstream issue ?
> >
> > Unfortunately no, I can still reproduce the issue on Ubuntu 18.04 with Firefox 112.0b2 snap, but unfortunately, I still don't know how to file the issue. If you could provide me with some guidance on how to do this it would be great. Thank you!
>
> You need to file an issue on Launchpad https://launchpad.net/ against the Firefox package.

I hope this helps https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/2011708/

Amin, can you check what is missing to backport to 18.04 and whether this is fixable ?

After discussing with Canonical folks, 18.04 is EOL so this cannot be fixed.