tripleo

openstack-tox-linters failure against tripleo-repos

Bug #2002526 reported by Sandeep Yadav on 2023-01-11

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	Critical	Sandeep Yadav	tripleo antelope-1

Bug Description

Description:

openstack-tox-linters failure against tripleo-repos: So far noticed against tripleo-quickstart and tripleo-ci.

Issue started on 11th Jaunary:

https://zuul.openstack.org/builds?job_name=openstack-tox-linters&project=%09openstack%2Ftripleo-ci&project=%09openstack%2Ftripleo-quickstart&skip=0

Error Snippet:

https://4ce3a51ae6abacf62f47-457a62f3edf936e12b25b29cc986a36d.ssl.cf1.rackcdn.com/863638/1/check/openstack-tox-linters/de3e937/tox/linters/1-commands%5B0%5D.log

~~~
[34mroles/environment/setup/tasks/main.yml[0m:6: [91myaml[0m [2mwrong indentation: expected at least 3[0m [2;91m(indentation)[0m
[34mroles/repo-setup/tasks/tripleo-get-hash-set-fact-no-collections.yml[0m:30: [91mvar-naming[0m [2mTask uses 'set_fact' to define variables that violates variable naming standards[0m
[34mroles/repo-setup/tasks/tripleo-get-hash-set-fact.yml[0m:29: [91mvar-naming[0m [2mTask uses 'set_fact' to define variables that violates variable naming standards[0m
~~~

https://e76b8a042504872b0b7d-f18cd0734c7002742f0baf633d0573f2.ssl.cf1.rackcdn.com/865240/2/gate/openstack-tox-linters/5480d23/tox/linters/4-commands%5B0%5D.log

~~~
WARNING Listing 1 violation(s) that are fatal
[34mplaybooks/tripleo-buildimages/run-v3.yaml[0m:5: [91myaml[0m [2mwrong indentation: expected at least 3[0m [2;91m(indentation)[0m
You can skip specific rules or tags by adding them to your configuration file:
~~~

Tags:

Sandeep Yadav (sandeepyadav93) on 2023-01-11

tags:

added: promotion-blocker

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-01-11: Related fix proposed to tripleo-ci (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-ci/+/869816

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-01-11: Fix proposed to tripleo-quickstart (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-quickstart/+/869820

Changed in tripleo:
status:	Triaged → In Progress

Revision history for this message

Sandeep Yadav (sandeepyadav93) wrote on 2023-01-11:

Root cause, Issue appears after new release of yamllint 1.29.0, released on 10th January: https://pypi.org/project/yamllint/1.29.0/#history

I was able to reproduce the issue locally:-

With 1.28.0 version -> we don't see this error-> wrong indentation: expected at least 3
~~~
$ pip list | grep -i yamllint
yamllint 1.28.0

$ pwd
/tmp/debug/tripleo-quickstart/roles/environment/setup/tasks

$ yamllint main.yml
main.yml
  2:1 warning missing document start "---" (document-start)
  2:81 error line too long (96 > 80 characters) (line-length)
  15:81 error line too long (85 > 80 characters) (line-length)
  69:81 error line too long (81 > 80 characters) (line-length)
  75:81 error line too long (82 > 80 characters) (line-length)
~~~

In version 1.29.0 we start seeing a new error: wrong indentation: expected at least 3 (indentation)
~~~
$ pip install yamllint==1.29.0
Collecting yamllint==1.29.0
  Using cached yamllint-1.29.0-py3-none-any.whl (62 kB)
Requirement already satisfied: setuptools in /tmp/test/lib/python3.9/site-packages (from yamllint==1.29.0) (59.5.0)
Requirement already satisfied: pyyaml in /tmp/test/lib64/python3.9/site-packages (from yamllint==1.29.0) (6.0)
Requirement already satisfied: pathspec>=0.5.3 in /tmp/test/lib/python3.9/site-packages (from yamllint==1.29.0) (0.10.3)
Installing collected packages: yamllint
  Attempting uninstall: yamllint
    Found existing installation: yamllint 1.28.0
    Uninstalling yamllint-1.28.0:
      Successfully uninstalled yamllint-1.28.0
Successfully installed yamllint-1.29.0

.
$ yamllint main.yml
main.yml
  2:1 warning missing document start "---" (document-start)
  2:81 error line too long (96 > 80 characters) (line-length)
  6:3 error wrong indentation: expected at least 3 (indentation) >>>>> new error
  15:81 error line too long (85 > 80 characters) (line-length)
  69:81 error line too long (81 > 80 characters) (line-length)
  75:81 error line too long (82 > 80 characters) (line-length)
~~~

Root cause, Issue appears after new release of yamllint 1.29.0, released on 10th January: https://pypi.org/project/yamllint/1.29.0/#history

I was able to reproduce the issue locally:-

With 1.28.0 version -> we don't see this error-> wrong indentation: expected at least 3
~~~
$ pip list | grep -i yamllint
yamllint          1.28.0

$ pwd
/tmp/debug/tripleo-quickstart/roles/environment/setup/tasks

$ yamllint main.yml 
main.yml
  2:1       warning  missing document start "---"  (document-start)
  2:81      error    line too long (96 > 80 characters)  (line-length)
  15:81     error    line too long (85 > 80 characters)  (line-length)
  69:81     error    line too long (81 > 80 characters)  (line-length)
  75:81     error    line too long (82 > 80 characters)  (line-length)
~~~

In version 1.29.0 we start seeing a new error: wrong indentation: expected at least 3  (indentation)
~~~
$ pip install yamllint==1.29.0
Collecting yamllint==1.29.0
  Using cached yamllint-1.29.0-py3-none-any.whl (62 kB)
Requirement already satisfied: setuptools in /tmp/test/lib/python3.9/site-packages (from yamllint==1.29.0) (59.5.0)
Requirement already satisfied: pyyaml in /tmp/test/lib64/python3.9/site-packages (from yamllint==1.29.0) (6.0)
Requirement already satisfied: pathspec>=0.5.3 in /tmp/test/lib/python3.9/site-packages (from yamllint==1.29.0) (0.10.3)
Installing collected packages: yamllint
  Attempting uninstall: yamllint
    Found existing installation: yamllint 1.28.0
    Uninstalling yamllint-1.28.0:
      Successfully uninstalled yamllint-1.28.0
Successfully installed yamllint-1.29.0

.
$ yamllint main.yml 
main.yml
  2:1       warning  missing document start "---"  (document-start)
  2:81      error    line too long (96 > 80 characters)  (line-length)
  6:3       error    wrong indentation: expected at least 3  (indentation) >>>>> new error
  15:81     error    line too long (85 > 80 characters)  (line-length)
  69:81     error    line too long (81 > 80 characters)  (line-length)
  75:81     error    line too long (82 > 80 characters)  (line-length)
~~~

Sandeep Yadav (sandeepyadav93) on 2023-01-11

Changed in tripleo:
assignee:	nobody → Sandeep Yadav (sandeepyadav93)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-01-11: Related fix merged to tripleo-ci (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ci/+/869816
Committed: https://opendev.org/openstack/tripleo-ci/commit/e732f1fa2b01f44ee25d153ec49112cf23f9814d
Submitter: "Zuul (22348)"
Branch: master

commit e732f1fa2b01f44ee25d153ec49112cf23f9814d
Author: Sandeep Yadav <email address hidden>
Date: Wed Jan 11 17:44:15 2023 +0530

Correct indentation in run-v3.yaml

ansible-lint is complaining about wrong indentation[1],
correcting indentation with this patch.

[1] https://e76b8a042504872b0b7d-f18cd0734c7002742f0baf633d0573f2.ssl.cf1.rackcdn.com/865240/2/gate/openstack-tox-linters/5480d23/tox/linters/4-commands%5B0%5D.log

Related-Bug: #2002526
Change-Id: I2d68592aa1c840acc483ba29a48494bb0dabc3be

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-01-12: Fix merged to tripleo-quickstart (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-quickstart/+/869820
Committed: https://opendev.org/openstack/tripleo-quickstart/commit/05e2978334f64cadf735921fa0a2d845eb5ed71b
Submitter: "Zuul (22348)"
Branch: master

commit 05e2978334f64cadf735921fa0a2d845eb5ed71b
Author: Sandeep Yadav <email address hidden>
Date: Wed Jan 11 18:26:24 2023 +0530

Correct indentation in environment role

ansible-lint is complaining about wrong indentation[1],
correcting indentation with this patch.

[1] https://cf3e172ed2d7be9bae50-58eae736b511220091705f1aa1981af1.ssl.cf2.rackcdn.com/865238/6/check/openstack-tox-linters/01c1fa8/job-output.txt

Closes-Bug: #2002526
Change-Id: Id9976fe61e1601a50ce31ff72cbbdb7aa4c62172

Changed in tripleo:
status:	In Progress → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.