flake8 6.0.0 raises ValueError for inline comments on ignore rule lines
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MongoDB Charm |
Fix Released
|
Undecided
|
Mert Kirpici | ||
Nagios Charm |
Fix Released
|
Undecided
|
Mert Kirpici | ||
Rsyslog Forwarder HA Charm |
Fix Released
|
Undecided
|
Mert Kirpici | ||
charm-cloudsupport |
Fix Released
|
Undecided
|
Mert Kirpici | ||
charm-duplicity |
Fix Released
|
Undecided
|
Nishant Dash | ||
charm-openstack-service-checks |
Fix Released
|
Undecided
|
Mert Kirpici | ||
charm-storage-connector |
Fix Released
|
Undecided
|
Mert Kirpici | ||
hw-health-charm |
Fix Released
|
Undecided
|
Ashley James |
Bug Description
This issue is currently affecting multiple charms after the flake8 6.0.0 release. flake8 expects to find the comments on their separate lines.
miles@mertkirpi
Running lint checks
lint installed: black==
lint run-test-pre: PYTHONHASHSEED=
lint run-test: commands[0] | flake8
Traceback (most recent call last):
File "/home/
sys.
File "/home/
app.run(argv)
File "/home/
self._run(argv)
File "/home/
self.
File "/home/
self.plugins, self.options = parse_args(argv)
File "/home/
opts = aggregator.
File "/home/
parsed_config = config.
File "/home/
raise ValueError(
ValueError: Error code '#TODO' supplied to 'ignore' option does not match '^[A-Z]
ERROR: InvocationError for command /home/miles/
_______
ERROR: lint: commands failed
make: *** [Makefile:63: lint] Error 1
Related branches
- Erhan Sunar (community): Approve
- Ramesh Sattaru (community): Approve
- π€ prod-jenkaas-bootstack: Approve (continuous-integration)
- BootStack Reviewers: Pending requested
-
Diff: 82 lines (+22/-12)3 files modifiedsrc/files/sas3ircu/check_sas3ircu.py (+2/-2)
src/lib/hwhealth/tools.py (+6/-3)
src/tox.ini (+14/-7)
- Ramesh Sattaru (community): Approve
- π€ prod-jenkaas-bootstack: Approve (continuous-integration)
- Eric Chen: Approve
- BootStack Reviewers: Pending requested
-
Diff: 58 lines (+6/-5)3 files modifiedtests/functional/conftest.py (+3/-3)
tests/functional/test_config.py (+1/-1)
tox.ini (+2/-1)
- Erhan Sunar (community): Approve
- π€ prod-jenkaas-bootstack: Approve (continuous-integration)
- Eric Chen: Pending requested
- Robert Gildein: Pending requested
- Chi Wai CHAN: Pending requested
- BootStack Reviewers: Pending requested
- Martin Kalcok: Pending requested
-
Diff: 1374 lines (+715/-284)13 files modifiedsrc/README.md (+13/-5)
src/actions.yaml (+38/-1)
src/actions/actions.py (+36/-10)
src/actions/remove-all-but-n-full (+1/-0)
src/actions/remove-all-inc-of-but-n-full (+1/-0)
src/actions/remove-older-than (+1/-0)
src/lib/lib_duplicity.py (+52/-56)
src/tests/functional/requirements.txt (+0/-1)
src/tests/functional/tests/test_duplicity.py (+337/-194)
src/tests/functional/tests/tests.yaml (+3/-0)
src/tests/unit/test_actions.py (+106/-3)
src/tests/unit/test_lib_duplicity.py (+123/-13)
src/tox.ini (+4/-1)
- Ramesh Sattaru (community): Approve
- Erhan Sunar (community): Approve
- π€ prod-jenkaas-bootstack: Approve (continuous-integration)
-
Diff: 14 lines (+2/-1)1 file modifiedtox.ini (+2/-1)
- Erhan Sunar (community): Approve
- Ramesh Sattaru (community): Approve
- π€ prod-jenkaas-bootstack: Approve (continuous-integration)
- BootStack Reviewers: Pending requested
-
Diff: 20 lines (+6/-3)1 file modifiedtox.ini (+6/-3)
- Ramesh Sattaru (community): Approve
- π€ prod-jenkaas-bootstack: Approve (continuous-integration)
- BootStack Reviewers: Pending requested
-
Diff: 17 lines (+4/-2)1 file modifiedtox.ini (+4/-2)
- Erhan Sunar (community): Approve
- π€ prod-jenkaas-bootstack: Needs Fixing (continuous-integration)
- Eric Chen: Approve
- Ramesh Sattaru (community): Approve
-
Diff: 153 lines (+27/-4)8 files modifiedfiles/plugins/stale_server_check.py (+3/-0)
lib/lib_cloudsupport.py (+3/-0)
lib/os_testing.py (+12/-0)
lib/qssh.py (+2/-0)
tests/functional/tests/modules/setup.py (+1/-0)
tests/functional/tests/modules/test_cloudsupport.py (+1/-0)
tests/functional/tests/modules/test_utils.py (+1/-0)
tox.ini (+4/-4)
- Ramesh Sattaru (community): Approve
- Erhan Sunar (community): Approve
- π€ prod-jenkaas-bootstack: Approve (continuous-integration)
- BootStack Reviewers: Pending requested
-
Diff: 23 lines (+8/-4)1 file modifiedsrc/tox.ini (+8/-4)
Changed in charm-mongodb: | |
assignee: | nobody → Mert Kirpici (mertkirpici) |
Changed in charm-rsyslog-forwarder-ha: | |
assignee: | nobody → Mert Kirpici (mertkirpici) |
Changed in charm-cloudsupport: | |
assignee: | nobody → Mert Kirpici (mertkirpici) |
Changed in charm-openstack-service-checks: | |
assignee: | nobody → Mert Kirpici (mertkirpici) |
Changed in charm-storage-connector: | |
assignee: | nobody → Mert Kirpici (mertkirpici) |
Changed in charm-mongodb: | |
status: | New → In Progress |
Changed in charm-rsyslog-forwarder-ha: | |
status: | New → In Progress |
Changed in charm-cloudsupport: | |
status: | New → In Progress |
Changed in charm-openstack-service-checks: | |
status: | New → In Progress |
Changed in charm-storage-connector: | |
status: | New → In Progress |
Changed in charm-nagios: | |
status: | New → In Progress |
assignee: | nobody → Mert Kirpici (mertkirpici) |
Changed in charm-storage-connector: | |
status: | In Progress → Fix Committed |
tags: | added: bseng-619 |
Changed in charm-mongodb: | |
status: | In Progress → Fix Committed |
Changed in charm-nagios: | |
status: | In Progress → Fix Committed |
Changed in charm-duplicity: | |
assignee: | nobody → Nishant Dash (dash3) |
status: | New → In Progress |
Changed in charm-rsyslog-forwarder-ha: | |
status: | In Progress → Fix Committed |
Changed in charm-cloudsupport: | |
status: | In Progress → Fix Committed |
Changed in charm-openstack-service-checks: | |
status: | In Progress → Fix Committed |
Changed in charm-duplicity: | |
status: | In Progress → Fix Committed |
Changed in charm-rsyslog-forwarder-ha: | |
milestone: | none → 23.01 |
Changed in charm-storage-connector: | |
milestone: | none → 23.01 |
Changed in charm-cloudsupport: | |
milestone: | none → 23.01 |
Changed in charm-duplicity: | |
milestone: | none → 23.01 |
Changed in charm-mongodb: | |
milestone: | none → 23.01 |
Changed in charm-nagios: | |
milestone: | none → 23.01 |
Changed in charm-openstack-service-checks: | |
milestone: | none → 23.01 |
Changed in charm-cloudsupport: | |
status: | Fix Committed → Fix Released |
Changed in charm-duplicity: | |
status: | Fix Committed → Fix Released |
Changed in charm-nagios: | |
status: | Fix Committed → Fix Released |
Changed in charm-openstack-service-checks: | |
status: | Fix Committed → Fix Released |
Changed in charm-rsyslog-forwarder-ha: | |
status: | Fix Committed → Fix Released |
Changed in charm-storage-connector: | |
status: | Fix Committed → Fix Released |
Changed in charm-mongodb: | |
status: | Fix Committed → Fix Released |
Changed in charm-hw-health: | |
assignee: | nobody → Ashley James (dashmage) |
status: | New → In Progress |
Changed in charm-hw-health: | |
status: | In Progress → Fix Released |
milestone: | none → 23.01 |
Changed in charm-hw-health: | |
status: | Fix Released → Fix Committed |
milestone: | 23.01 → none |
Changed in charm-hw-health: | |
milestone: | none → 23.04 |
Changed in charm-hw-health: | |
status: | Fix Committed → Fix Released |