Hi,
while trying to review https://review.opendev.org/c/openstack/tripleo-common/+/859403 which is a backport from wallaby we get an error:
TASK [tripleo-upgrade : set inventory facts] ***********************************
Thursday 13 October 2022 12:32:49 +0000 (0:00:01.946) 0:01:24.815 ******
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: KeyError: 'overcloud_excluded_overcloud'
fatal: [undercloud]: FAILED! => {"changed": false}
in https://zuul.opendev.org/t/openstack/build/3f0c74473e5e4da7b028cdc750ceabca
The associated task is
- name: set inventory facts
set_fact:
inventory_rolemap: "{{ upgrade_tripleo_inventory.content | b64decode | to_inventory_rolemap }}"
inventory_hostmap: "{{ upgrade_tripleo_inventory.content | b64decode | to_inventory_hostmap }}"
inventory_roles: "{{ upgrade_tripleo_inventory.content | b64decode | to_inventory_roles }}"
from https://opendev.org/openstack/tripleo-upgrade/src/branch/stable/train/tasks/common/load_roles_from_inventory.yaml#L15-L19
The error comes from to_inventory_rolemap.
By adding:
@@ -42,9 +42,11 @@ def to_inventory_hostmap(data):
break
else:
group_host_map[group] = []
- for child in inventory[group]['children']:
- group_host_map[group] += group_host_map[child]
- group_host_map[group].sort()
+ # take into account the case for excluded overcloud
+ if child in group_role_map:
+ for child in inventory[group]['children']:
+ group_host_map[group] += group_host_map[child]
+ group_host_map[group].sort()
return group_host_map
in https://opendev.org/openstack/tripleo-upgrade/src/branch/stable/train/filter_plugins/tripleo_upgrade.py#L51
the error goes away.
But why the exclude group doesn't make any failure for wallaby and master is still to be found.
@damani42 as you worked on this could you have a look ?
Fix proposed to branch: stable/train
Review: https:/