Staff catalog - Chrome update has broken Item Hold link

IRC comments at: http://irc.evergreen-ils.org/evergreen/2022-03-04#i_502511

Marking Confirmed, setting Importance to High as the workarounds for this aren't great.

Workaround options are:

Item status - Request item
Traditional catalog - Copy hold, but bug 1939426 is an issue there

Out of curiosity, what does that tool-tip do? It seems redundant on the front-end, at least, since it just repeats the already visible text.

Shula - it is so that you can see the full text in a grid cell that is cut off because the column is too narrow. (However, it does it for all columns whether you can see the full text or not.)

As it happens, I have a branch to address exactly this:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1964019-disable-some-tooltips

It disables tooltips on columns in that grid that have templates for "action-y" cells.

I can say that's impacting us in 3.7.2 as well.

Thanks, Mike! My sign off is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp-1964019-disable-some-tooltips-signoff

I have one question about this fix. It disables tooltips on the following columns:

Holdable (which fixes the described issue)
Barcode
Call Number/Item Notes

With tooltips disabled, certain column configurations or screen resolutions can result in the user having no way to see the entire call number label or barcode in the item table.

How would folks feel about disabling the tooltip on just the 'Holdable' column since the other action-y columns are not affected by this issue?

I'm fine with it either way. However, the advantage of keeping it as written is that it would also help with this one: https://bugs.launchpad.net/evergreen/+bug/1963708

A huge thanks to a staff member at a Westchester library for pointing us to the source of the Holdable column woes. Something about the hold link divs being wrapped in a <span> messes with the positioning somehow. Since all this span does is show its contents or not based on the item holdable flag changing it to a <div> allows things to work as they did in Chrome < 99.

Branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1964019_not_that_spanner / working/user/jboyer/lp1964019_not_that_spanner

Removing my signoff and adding needsdiscussion on which approach we should use.

While I'm not sure that having templated cells show their whole content as a tooltip is normally useful, I'm in favor of "the smallest change that could possibly work" at least until there's broader consensus on the behavior. I've signed off Jason's branch at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp1964019_not_that_spanner_signoff

I agree with Mike. Jason's branch doesn't help with bug 1963708, but it restores the pre-Chrome update tooltip behavior.

Pushed to master, rel_3_8, and rel_3_7. Thanks, Terran, Mike and Jason, and the staff member at a Westchester library!