push_destination support lacking in 'openstack overcloud deploy ceph --container-image-prepare'

Bug #1958524 reported by John Fulton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
John Fulton

Bug Description

When 'openstack overcloud deploy ceph' is passed --container-image-prepare with a file with a push_destination then, then the resulting image parameters should be modified to refer to the images in push_destination instead of namespace.

1. Set "push_destination: true" in containers-prepare-parameter.yaml as described in [1]

2. Run 'openstack tripleo container image prepare --environment-file containers-prepare-parameter.yaml' to push containers to the local registry

3. Run 'openstack overcloud deploy ceph --container-image-prepare containers-prepare-parameter.yaml'

Results:
overcloud tries to download directly container from ceph_namespace

Expected Results:
overcloud tries to download directly container from undercloud registry

[1] https://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/deployment/container_image_prepare.html#undercloud-registry

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-ansible (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/827690

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/827690
Committed: https://opendev.org/openstack/tripleo-ansible/commit/4de0bc4d94f2fa1c1234db4519aa316b96495108
Submitter: "Zuul (22348)"
Branch: master

commit 4de0bc4d94f2fa1c1234db4519aa316b96495108
Author: John Fulton <email address hidden>
Date: Thu Feb 3 15:17:17 2022 +0000

    Add playbooks to config overcloud hosts and container regsitry

    Add two playbooks which call the tripleo_hosts_entries and
    tripleo_podman roles. These roles are usually called from
    THT deploy-steps but in order to deploy Ceph before the
    overcloud the 'openstack overcloud ceph deploy' command
    needs to be able to call them earlier so these two playbooks
    provide it an interface to do so.

    See I24bea131cc949888518994a3aa08c200d579cb7d which depends-on
    this patch.

    Related-Bug: 1958524
    Change-Id: Ibaeb1249ae02651cbefba75d0912da205880a495

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/825416
Committed: https://opendev.org/openstack/python-tripleoclient/commit/3aae1ea80891539b2734f436929c2ae8056cfc61
Submitter: "Zuul (22348)"
Branch: master

commit 3aae1ea80891539b2734f436929c2ae8056cfc61
Author: John Fulton <email address hidden>
Date: Thu Jan 20 01:20:45 2022 +0000

    Support Deployed Ceph container push_destination

    When 'openstack overcloud deploy ceph' is passed
    --container-image-prepare with a file with a
    push_destination then, then the resulting image
    parameters should be modified to refer to the
    images in push_destination instead of namespace.

    In order to support push_destination the overcloud
    /etc/containers/registries.conf and /etc/hosts must
    be updated so that the undercloud hostname can be
    resolved and so that podman will pull containers
    from it as a registry. Calls to tripleo-ansible
    roles tripleo_hosts_entries and tripleo_podman
    are thus required.

    Closes-Bug: 1958524
    Depends-On: Ibaeb1249ae02651cbefba75d0912da205880a495
    Change-Id: I24bea131cc949888518994a3aa08c200d579cb7d

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/828561

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-ansible (stable/wallaby)

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/828562

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-tripleoclient (stable/wallaby)

Change abandoned by "John Fulton <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/828561
Reason: removing from gate, will restore

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-ansible (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/828562
Committed: https://opendev.org/openstack/tripleo-ansible/commit/4e72d0ff92999e8f25c92fdd6fa6ea1d0a133cbf
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 4e72d0ff92999e8f25c92fdd6fa6ea1d0a133cbf
Author: John Fulton <email address hidden>
Date: Thu Feb 3 15:17:17 2022 +0000

    Add playbooks to config overcloud hosts and container regsitry

    Add two playbooks which call the tripleo_hosts_entries and
    tripleo_podman roles. These roles are usually called from
    THT deploy-steps but in order to deploy Ceph before the
    overcloud the 'openstack overcloud ceph deploy' command
    needs to be able to call them earlier so these two playbooks
    provide it an interface to do so.

    See I24bea131cc949888518994a3aa08c200d579cb7d which depends-on
    this patch.

    Related-Bug: 1958524
    Change-Id: Ibaeb1249ae02651cbefba75d0912da205880a495
    (cherry picked from commit 4de0bc4d94f2fa1c1234db4519aa316b96495108)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-docs (master)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/828561
Committed: https://opendev.org/openstack/python-tripleoclient/commit/192802ea5806093dca48c793827eae0bd2830e09
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 192802ea5806093dca48c793827eae0bd2830e09
Author: John Fulton <email address hidden>
Date: Thu Jan 20 01:20:45 2022 +0000

    Support Deployed Ceph container push_destination

    When 'openstack overcloud deploy ceph' is passed
    --container-image-prepare with a file with a
    push_destination then, then the resulting image
    parameters should be modified to refer to the
    images in push_destination instead of namespace.

    In order to support push_destination the overcloud
    /etc/containers/registries.conf and /etc/hosts must
    be updated so that the undercloud hostname can be
    resolved and so that podman will pull containers
    from it as a registry. Calls to tripleo-ansible
    roles tripleo_hosts_entries and tripleo_podman
    are thus required.

    Conflicts:
    - tripleoclient/v2/overcloud_ceph.py
    - tripleoclient/tests/v2/overcloud_ceph/test_overcloud_ceph.py

    Closes-Bug: 1958524
    Depends-On: Ibaeb1249ae02651cbefba75d0912da205880a495
    Change-Id: I24bea131cc949888518994a3aa08c200d579cb7d
    (cherry picked from commit 3aae1ea80891539b2734f436929c2ae8056cfc61)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-docs (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-docs/+/828930
Committed: https://opendev.org/openstack/tripleo-docs/commit/8cf632eb1b9a9973c0f282f3d772f9db7399a9a4
Submitter: "Zuul (22348)"
Branch: master

commit 8cf632eb1b9a9973c0f282f3d772f9db7399a9a4
Author: John Fulton <email address hidden>
Date: Fri Feb 11 17:23:01 2022 -0500

    Document Ceph spec, container, and single-host options

    This patch updates the deployed_ceph and standalone documents to
    describe the --skip-container-registry-config, --skip-hosts-config
    and --single-host-defaults options to 'openstack overcloud deploy
    ceph'. It also documents the 'openstack overcloud ceph spec' command.

    Change-Id: I88d224f618b66b5e3f71264ed6b05152eb1ebe42
    Releated-Bug: 1958884
    Releated-Bug: 1958524

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 18.0.0

This issue was fixed in the openstack/python-tripleoclient 18.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.