precheck should fail immediately if the conf file is not found
Bug #1958144 reported by
Jeff Lane
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Provider for Plainbox - Canonical Certification Server |
Fix Released
|
Medium
|
Jeff Lane |
Bug Description
See attached screenshot.
A partner was recently running the precheck script and sent me a screenshot with a question about the process... I noticed in their screenshot that /etc/xdg/
The precheck script depends on that conf file and so should immediately fail and exit if the file isn't found.
Related branches
~bladernr/plainbox-provider-certification-server:1958144-precheck-fail-on-file-not-found
Merged
into
plainbox-provider-certification-server:master
at
revision 63fb95ee71ecefbc8a15866daf48b32272e6056b
- Rod Smith: Approve
-
Diff: 336 lines (+60/-52)1 file modifiedtools/canonical-certification-precheck (+60/-52)
Changed in plainbox-provider-certification-server: | |
status: | In Progress → Fix Committed |
Changed in plainbox-provider-certification-server: | |
status: | Fix Committed → Fix Released |
tags: | added: servcert-319 |
To post a comment you must log in.
The problem report is almost certainly caused by the incomplete APT setup; the config file IS present, just under another name. This was supposed to be fixed by https:/ /code.launchpad .net/~rodsmith/ plainbox- provider- certification- server/ +git/plainbox- provider- certification- server/ +ref/fix- apt-errors- in-precheck, but it looks like it's not running early enough in the script. I'm looking into that now.