tripleo

pre-flight validation for local_ip may fail for IPv6

Bug #1953552 reported by Harald Jensås
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Harald Jensås
tripleo xena-3

Bug Description

Changing the local_ip is not allowed. Existing IP: fd00:fd00:fd00::1/64, Configured IP: fd00:fd00:fd00:0000::1/64

An error occurred during configuration validation, please check your host configuration and try again.

Error message: Changing the local_ip is not allowed. Existing IP: fd00:fd00:fd00::1/64, Configured IP: fd00:fd00:fd00:0000::1/64

https://opendev.org/openstack/python-tripleoclient/src/branch/master/tripleoclient/v1/undercloud_preflight.py#L315

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/820958

Changed in tripleo:
status: New → In Progress
Harald Jensås (harald-jensas)
Changed in tripleo:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/820958
Committed: https://opendev.org/openstack/python-tripleoclient/commit/02b67f8e63833a783ad83ece6ecdb1f0eb080ed0
Submitter: "Zuul (22348)"
Branch: master

commit 02b67f8e63833a783ad83ece6ecdb1f0eb080ed0
Author: Harald Jensås <email address hidden>
Date: Tue Dec 7 23:37:30 2021 +0100

    Use netaddr when comparing local_ip for changes

    In undercloud preflight validations the IP address in
    config is compared to the IP address on the deployed
    undercloud. For IPv6 the string discovered on the
    system may be in a different format, representing the
    same actual IP address and netmask but written using a
    different valid syntax.

    Load the existing IP and config IP as a netaddr.IPNetwork,
    and compare both the networks and IPs to ensure we compare
    the actuall address and network, not the strings.

    Closes-Bug: #1953552
    Change-Id: I42531b4e6f7b3b18ae085cc2eb36234cb306b375

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/821260

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/821260
Committed: https://opendev.org/openstack/python-tripleoclient/commit/eadbcec0ab5cd8a61bd5f06a418edda506da582c
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit eadbcec0ab5cd8a61bd5f06a418edda506da582c
Author: Harald Jensås <email address hidden>
Date: Tue Dec 7 23:37:30 2021 +0100

    Use netaddr when comparing local_ip for changes

    In undercloud preflight validations the IP address in
    config is compared to the IP address on the deployed
    undercloud. For IPv6 the string discovered on the
    system may be in a different format, representing the
    same actual IP address and netmask but written using a
    different valid syntax.

    Load the existing IP and config IP as a netaddr.IPNetwork,
    and compare both the networks and IPs to ensure we compare
    the actuall address and network, not the strings.

    Closes-Bug: #1953552
    Change-Id: I42531b4e6f7b3b18ae085cc2eb36234cb306b375
    (cherry picked from commit 02b67f8e63833a783ad83ece6ecdb1f0eb080ed0)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/825934

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/825935

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/825936

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/825934
Committed: https://opendev.org/openstack/python-tripleoclient/commit/e1e54d2bef76959f07b6f2662c61989183d77cf4
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit e1e54d2bef76959f07b6f2662c61989183d77cf4
Author: Harald Jensås <email address hidden>
Date: Tue Dec 7 23:37:30 2021 +0100

    Use netaddr when comparing local_ip for changes

    In undercloud preflight validations the IP address in
    config is compared to the IP address on the deployed
    undercloud. For IPv6 the string discovered on the
    system may be in a different format, representing the
    same actual IP address and netmask but written using a
    different valid syntax.

    Load the existing IP and config IP as a netaddr.IPNetwork,
    and compare both the networks and IPs to ensure we compare
    the actuall address and network, not the strings.

    Closes-Bug: #1953552
    Change-Id: I42531b4e6f7b3b18ae085cc2eb36234cb306b375
    (cherry picked from commit 02b67f8e63833a783ad83ece6ecdb1f0eb080ed0)

tags: added: in-stable-victoria
tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/825935
Committed: https://opendev.org/openstack/python-tripleoclient/commit/731b34a485dfc01c089135e9454ae41304c94313
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 731b34a485dfc01c089135e9454ae41304c94313
Author: Harald Jensås <email address hidden>
Date: Tue Dec 7 23:37:30 2021 +0100

    Use netaddr when comparing local_ip for changes

    In undercloud preflight validations the IP address in
    config is compared to the IP address on the deployed
    undercloud. For IPv6 the string discovered on the
    system may be in a different format, representing the
    same actual IP address and netmask but written using a
    different valid syntax.

    Load the existing IP and config IP as a netaddr.IPNetwork,
    and compare both the networks and IPs to ensure we compare
    the actuall address and network, not the strings.

    Closes-Bug: #1953552
    Change-Id: I42531b4e6f7b3b18ae085cc2eb36234cb306b375
    (cherry picked from commit 02b67f8e63833a783ad83ece6ecdb1f0eb080ed0)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/train)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/825936
Committed: https://opendev.org/openstack/python-tripleoclient/commit/ad0c72436498c5d2dfd2499638fb0cc9b0ae36b4
Submitter: "Zuul (22348)"
Branch: stable/train

commit ad0c72436498c5d2dfd2499638fb0cc9b0ae36b4
Author: Harald Jensås <email address hidden>
Date: Tue Dec 7 23:37:30 2021 +0100

    Use netaddr when comparing local_ip for changes

    In undercloud preflight validations the IP address in
    config is compared to the IP address on the deployed
    undercloud. For IPv6 the string discovered on the
    system may be in a different format, representing the
    same actual IP address and netmask but written using a
    different valid syntax.

    Load the existing IP and config IP as a netaddr.IPNetwork,
    and compare both the networks and IPs to ensure we compare
    the actuall address and network, not the strings.

    Closes-Bug: #1953552
    Change-Id: I42531b4e6f7b3b18ae085cc2eb36234cb306b375
    (cherry picked from commit 02b67f8e63833a783ad83ece6ecdb1f0eb080ed0)

Harald Jensås (harald-jensas)
Changed in tripleo:
assignee: nobody → Harald Jensås (harald-jensas)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 13.4.6

This issue was fixed in the openstack/python-tripleoclient 13.4.6 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 18.0.0

This issue was fixed in the openstack/python-tripleoclient 18.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 14.3.0

This issue was fixed in the openstack/python-tripleoclient 14.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 16.5.0

This issue was fixed in the openstack/python-tripleoclient 16.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.