Evergreen

Check Out Fails Silently if Operating Hours of Operation Set to Closed 7 Days a Week

Bug #1944601 reported by Jessica Woolford
26
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Medium
Unassigned
Evergreen 3.11.2
3.10
Fix Committed
Medium
Unassigned
Evergreen 3.10.4

Bug Description

3.5+

When a library is closed 7 days a week, check out (and renewal) can fail with no feedback in the staff client.

See IRC initial discussion here: http://irc.evergreen-ils.org/evergreen/2021-09-21#i_491808

And possible solutions here: http://irc.evergreen-ils.org/evergreen/2021-09-22#i_491912

And here: http://irc.evergreen-ils.org/evergreen/2021-09-22#i_491970

Jessica Woolford (jwoolford)
summary: - Check Out Fails Silently is Operating Hours are Set to Closed 7 Days a
+ Check Out Fails Silently if Operating Hours are Set to Closed 7 Days a
Week
summary: - Check Out Fails Silently if Operating Hours are Set to Closed 7 Days a
- Week
+ Check Out Fails Silently if Operating Hours of Operation Set to Closed 7
+ Days a Week
Revision history for this message
Terran McCanna (tmccanna) wrote :

We just ran into this problem today and it took ages to figure out what was going on since there were no error messages in the client or the browser console.

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Steven Mayo (stmayo) wrote :

Minor update: to recreate this I had to not only set hours of operation to closed 7 days a week but also add a closure in the closed dates editor.

Changed in evergreen:
assignee: nobody → Steven Mayo (stmayo)
Revision history for this message
Steven Mayo (stmayo) wrote :

After checking my logs while recreating this, I've realized it causes the problem detailed here: https://bugs.launchpad.net/evergreen/+bug/1901191

Recursion doth recurse too much, methinks.

Revision history for this message
Steven Mayo (stmayo) wrote :

I think I have a fix for this. Haven't tested it thoroughly enough to add a pullrequest tag, but it's available here if anyone wants to check it out: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/smayo/lp1944601-Checkout_Fail_If_Closed_7_Days

I've added both a warning about doing this and an extra check that will ignore the hours of operation entirely to avoid looping and just set dates based on closures if they have.

Steven Mayo (stmayo)
tags: added: pullrequest
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Garry, Terran, Stephanie, and I tested this, and it worked well! We took a look at other places that use this perl code, and could not find any regressions. Signed off and pushed to main, rel_3_11, and rel_3_10. Thanks, Steven!

Changed in evergreen:
assignee: Steven Mayo (stmayo) → nobody
status: Confirmed → Fix Committed
milestone: none → 3.11.2
Terran McCanna (tmccanna)
tags: added: signedoff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.