[EHL][TGL][ADL] power management controller driver enabling

Bug #1943538 reported by Chao Qin
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
intel
New
Undecided
Unassigned
Lookout-canyon-series
Fix Released
Undecided
Philip Cox

Bug Description

Description
The driver is the Kernel gateway to the PMC hardware for Intel processors and it provides debug hooks to developers and end-users to quickly figure out why their platform is not entering a deeper idle state such as S0ix.

Hardware: ElkhartLake / TigerLake / AlderLake

Target Release: 21.04
Target Kernel: TBD

External links:
https://github.com/intel/linux-intel-quilt/tree/mainline-tracking-v5.13-yocto-210727T062416Z

X-HWE-Bug: Bug #1952153

Revision history for this message
Chao Qin (chaoqin) wrote :

Please find the following patches in the above external link

0001-platform-x86-intel-intel_pmc_core-Move-intel_pmc_.pmc_core
0002-platform-x86-intel-pmc-core-Add-Alderlake-support.pmc_core
0003-platform-x86-intel-pmc-core-Add-Latency-Tolerance.pmc_core
0004-platform-x86-intel-pmc-core-Add-Alder-Lake-low-po.pmc_core
0005-platform-x86-intel-pmc-core-Add-GBE-Package-C10-f.pmc_core
0006-PCI-ASPM-Enable-ASPM-for-links-under-VMD-domain.pmc_core
0007-SAUCE-PCI-ASPM-Enable-LTR-for-endpoints-behind-VM.pmc_core
0009-platform-x86-intel-pmc-core-Add-a-check-before-sa.pmc_core
0010-platform-x86-intel-pmc-core-fix-module-name-confl.pmc_core

Revision history for this message
Alex Hung (alexhung) wrote :

There is no "0008-...pmc_core" patch.

Is this intentional or is there a missing patch?

Revision history for this message
Chao Qin (chaoqin) wrote :

#0008 patch is the following one.
0008-pci-quirks-Enable-LTR-for-endpoints-behind-VMD-fo.pmc_core

Revision history for this message
Chao Qin (chaoqin) wrote :

0001-platform-x86-intel-intel_pmc_core-Move-intel_pmc_.pmc_core --> fa082a7cf5a66a42a06da048afd972e2cc1b67ea
0002-platform-x86-intel-pmc-core-Add-Alderlake-support.pmc_core --> bbab31101f44911b24c9da02733ce196e5702fea
0003-platform-x86-intel-pmc-core-Add-Latency-Tolerance.pmc_core --> ee7e89ff80063616c7f81b97ce7d38733019531a
0004-platform-x86-intel-pmc-core-Add-Alder-Lake-low-po.pmc_core --> 6cfce3ef806c1d458a816db7e63a1c13571abf86
0005-platform-x86-intel-pmc-core-Add-GBE-Package-C10-f.pmc_core --> 66a91c00218c5f5d19e5bfaada05432c672b8241
0006-PCI-ASPM-Enable-ASPM-for-links-under-VMD-domain.pmc_core
0007-SAUCE-PCI-ASPM-Enable-LTR-for-endpoints-behind-VM.pmc_core
0008-pci-quirks-Enable-LTR-for-endpoints-behind-VMD-fo.pmc_core
0009-platform-x86-intel-pmc-core-Add-a-check-before-sa.pmc_core --> drop it
0010-platform-x86-intel-pmc-core-fix-module-name-confl.pmc_core --> drop it

Revision history for this message
Alex Hung (alexhung) wrote :

The following two patches are already in intel-5.13-next.

0006-PCI-ASPM-Enable-ASPM-for-links-under-VMD-domain.pmc_cor (a3328fc2e82c047b3d2a0e45858106696b2cba7c)
Note: a3328fc2e82c04 seems to be more updated.

0007-SAUCE-PCI-ASPM-Enable-LTR-for-endpoints-behind-VM.pmc_core (851aa705006930e773300cb6daec904e0138256e)

Revision history for this message
Alex Hung (alexhung) wrote :

The following patch needs clarification from Intel.

0001-platform-x86-intel-intel_pmc_core-Move-intel_pmc_.pmc_core (fa082a7cf5a66a42a06da048afd972e2cc1b67ea)

This has conflicts and cannot be applied; however, this may not needed as it tries to move files and 5.13 does not move them.

Revision history for this message
Alex Hung (alexhung) wrote :

The following patch needs clarification from Intel.

0008-pci-quirks-Enable-LTR-for-endpoints-behind-VMD-fo.pmc_core

This is based on 0007 as its description says "based on the patch "SAUCE: PCI/ASPM: Enable LTR for endpoints behind VMD". While 0007 is included already (see #5), a later commit (a93165c14cd581 attached) replaced the modified table "vmd_bridge_tbl".

Can this a93165c14cd581 commit replace 0008 instead?

Alex Hung (alexhung)
description: updated
Revision history for this message
Alex Hung (alexhung) wrote :

@chaoqin,

I pushed the patches to https://code.launchpad.net/~alexhung/+git/focal/+ref/iotg-adl/1943538 with comments above.

Please have a look and keep me posted if there are improvements or fixes to be made

Revision history for this message
Chao Qin (chaoqin) wrote (last edit ):

v5.15 updates are as following

https://github.com/intel/linux-intel-quilt/tree/lts-v5.15.21-linux-220222T001242Z-1

0001-PCI-vmd-Honor-ACPI-_OSC-on-PCIe-features.pmc_core --> 04b12ef163d10e348db664900ae7f611b83c7a0e
0001-PCI-ASPM-Add-ASPM-BIOS-override-function.patch
0002-PCI-vmd-Override-ASPM-on-TGL-ADL-VMD-devices.patch

Ana Lasprilla (anamlt)
information type: Private → Public
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.